Skip to content

Commit 2ab4bb4

Browse files
committed
Log emulated access key instead of secret key
Unsure if this was instead for the initial development phases but we shouldn't be logging this now
1 parent 09a9de1 commit 2ab4bb4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/rest/TrinoGlueResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public TrinoGlueResource(ObjectMapper objectMapper, GlueRequestHandler requestHa
5959
@Produces(MediaType.APPLICATION_JSON)
6060
public Response gluePost(@Context Request request, @Context SigningMetadata signingMetadata, @Context RequestLoggingSession requestLoggingSession)
6161
{
62-
requestLoggingSession.logProperty("request.glue.emulated.key", signingMetadata.credential().secretKey());
62+
requestLoggingSession.logProperty("request.glue.emulated.access-key", signingMetadata.credential().accessKey());
6363

6464
String target = request.requestHeaders().unmodifiedHeaders().getFirst("x-amz-target")
6565
.orElseThrow(() -> InvalidInputException.builder().statusCode(BAD_REQUEST.getStatusCode()).build());

trino-aws-proxy/src/main/java/io/trino/aws/proxy/server/rest/TrinoS3Resource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ private void handler(Request request, Optional<Identity> identity, SigningMetada
135135

136136
requestLoggingSession.logProperty("request.parsed.bucket", parsedS3Request.bucketName());
137137
requestLoggingSession.logProperty("request.parsed.key", parsedS3Request.keyInBucket());
138-
requestLoggingSession.logProperty("request.emulated.key", signingMetadata.credential().secretKey());
138+
requestLoggingSession.logProperty("request.emulated.access-key", signingMetadata.credential().accessKey());
139139

140140
proxyClient.proxyRequest(identity, signingMetadata, parsedS3Request, asyncResponse, requestLoggingSession);
141141
}

0 commit comments

Comments
 (0)