Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

Commit fe092fb

Browse files
author
Pablo Mercado
authored
Merge pull request #89 from odacremolbap/task/use-latest-instead-of-dev
Use latest tag from triggermesh-core
2 parents 4524fe3 + 03dc044 commit fe092fb

File tree

3 files changed

+17
-22
lines changed

3 files changed

+17
-22
lines changed

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
find ./config/3*.yaml -exec cat {} \; -exec echo \; -exec echo --- \; -exec echo \; >> ./releases/manifests/triggermesh-core-crds.yaml
3030
find ./config/configmaps/*.yaml -exec cat {} \; -exec echo \; -exec echo --- \; -exec echo \; >> ./releases/manifests/triggermesh-core.yaml
3131
TAG=${GITHUB_REF#refs/*/}
32-
sed -e 's/:dev/:'"$TAG"'/g' -e 's#ko://github.com/triggermesh/triggermesh-core/cmd/core-controller#gcr.io/triggermesh/triggermesh-core:'"$TAG"'#g' ./config/5*.yaml >> ./releases/manifests/triggermesh-core.yaml
32+
sed -e 's/:latest/:'"$TAG"'/g' -e 's#ko://github.com/triggermesh/triggermesh-core/cmd/core-controller#gcr.io/triggermesh/triggermesh-core:'"$TAG"'#g' ./config/5*.yaml >> ./releases/manifests/triggermesh-core.yaml
3333
3434
- name: Run GoReleaser
3535
uses: goreleaser/goreleaser-action@v4

config/500-core-controller.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ spec:
6767
value: triggermesh.io
6868
# Deployment images
6969
- name: MEMORYBROKER_BROKER_IMAGE
70-
value: gcr.io/triggermesh/memory-broker:dev
70+
value: gcr.io/triggermesh/memory-broker:latest
7171
- name: REDISBROKER_REDIS_IMAGE
7272
value: redis/redis-stack-server:latest
7373
- name: REDISBROKER_BROKER_IMAGE
74-
value: gcr.io/triggermesh/redis-broker:dev
74+
value: gcr.io/triggermesh/redis-broker:latest
7575
# Pull policy for broker, REMOVE for production environments
7676
- name: REDISBROKER_BROKER_IMAGE_PULL_POLICY
7777
value: Always

docs/CONTRIBUTING.md

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,24 @@ We define _contributions_ as:
1414

1515
## Contents
1616

17-
1. [Code of Conduct](#code-of-conduct)
18-
19-
1. [Submitting Contributions](#submitting-contributions)
20-
- [Reporting Bugs](#reporting-bugs)
21-
- [Requesting Features and Enhancements](#requesting-features-and-enhancements)
22-
- [Submitting Code Changes](#submitting-code-changes)
23-
24-
1. [Development Guidelines](#development-guidelines)
25-
26-
1. [Prerequisites](#prerequisites)
17+
- [Contributing to TriggerMesh](#contributing-to-triggermesh)
18+
- [Contents](#contents)
19+
- [Code of Conduct](#code-of-conduct)
20+
- [Submitting Contributions](#submitting-contributions)
21+
- [Reporting Bugs](#reporting-bugs)
22+
- [Issue Description](#issue-description)
23+
- [Code Styling](#code-styling)
24+
- [Requesting Features and Enhancements](#requesting-features-and-enhancements)
25+
- [Submitting Code Changes](#submitting-code-changes)
26+
- [Development Guidelines](#development-guidelines)
27+
- [Prerequisites](#prerequisites)
2728
- [Go Toolchain](#go-toolchain)
2829
- [Kubernetes](#kubernetes)
2930
- [ko](#ko)
30-
31-
1. [Running the Controller](#running-the-controller)
31+
- [Running the Controller](#running-the-controller)
3232
- [Controller Configuration](#controller-configuration)
33+
- [Configuration Read From the Environment](#configuration-read-from-the-environment)
34+
- [Configuration Read From ConfigMaps](#configuration-read-from-configmaps)
3335
- [Locally](#locally)
3436

3537
## Code of Conduct
@@ -250,13 +252,6 @@ Additionally, the desired build version (container image) of each TriggerMesh co
250252
environment variables. The full list can be found inside the [controller's Deployment manifest][tm-allenvs]. By default,
251253
the controller uses the latest tagged public image from `gcr.io/triggermesh` for any given component.
252254

253-
To use your own image instead (e.g. the result of a development build), simply set the corresponding environment
254-
variable to the reference of the image to use. For example:
255-
256-
```sh
257-
# Use a custom build of the "Zendesk" event source adapter.
258-
export ZENDESKSOURCE_IMAGE=docker.io/myuser/zendesksource:devel
259-
```
260255

261256
##### Configuration Read From ConfigMaps
262257

0 commit comments

Comments
 (0)