Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

Commit 1e03317

Browse files
author
Pablo Mercado
authored
Merge pull request #87 from odacremolbap/task/default-redis-maxlen
Set default Redis maxlen
2 parents e25cb9f + 1b41d5c commit 1e03317

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

config/300-redisbroker.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ spec:
9797
streamMaxLen:
9898
description: Maximum number of items (approximate) the Redis stream can host.
9999
type: integer
100+
default: 1000
100101

101102
broker:
102103
description: Broker options.

pkg/reconciler/redisbroker/reconciler.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@ import (
2323
"github.com/triggermesh/triggermesh-core/pkg/reconciler/resources"
2424
)
2525

26+
const (
27+
defaultMaxLen = "1000"
28+
)
29+
2630
type reconciler struct {
2731
secretReconciler common.SecretReconciler
2832
saReconciler common.ServiceAccountReconciler
@@ -50,9 +54,11 @@ func redisDeploymentOption(rb *eventingv1alpha1.RedisBroker, redisSvc *corev1.Se
5054
}
5155
resources.ContainerAddEnvFromValue("REDIS_STREAM", stream)(c)
5256

53-
if rb.Spec.Redis != nil && rb.Spec.Redis.StreamMaxLen != nil && *rb.Spec.Redis.StreamMaxLen != 0 {
54-
resources.ContainerAddEnvFromValue("REDIS_STREAM_MAXLEN", stream)(c)
57+
maxLen := defaultMaxLen
58+
if rb.Spec.Redis != nil && rb.Spec.Redis.StreamMaxLen != nil {
59+
maxLen = strconv.Itoa(*rb.Spec.Redis.StreamMaxLen)
5560
}
61+
resources.ContainerAddEnvFromValue("REDIS_STREAM_MAXLEN", maxLen)(c)
5662

5763
if rb.IsUserProvidedRedis() {
5864
resources.ContainerAddEnvFromValue("REDIS_ADDRESS", rb.Spec.Redis.Connection.URL)(c)

0 commit comments

Comments
 (0)