Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

Commit de72346

Browse files
authored
Merge pull request #38 from triggermesh/ce-extensions
CE extensions in structured mode fixed
2 parents 2e8e056 + 088356b commit de72346

File tree

3 files changed

+70
-32
lines changed

3 files changed

+70
-32
lines changed

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ module github.com/triggermesh/aws-custom-runtime
33
go 1.15
44

55
require (
6+
github.com/cloudevents/sdk-go/v2 v2.6.1
67
github.com/google/uuid v1.2.0
78
github.com/kelseyhightower/envconfig v1.4.0
89
)

go.sum

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,51 @@
1+
github.com/cloudevents/sdk-go/v2 v2.6.1 h1:yHtzgmeBvc0TZx1nrnvYXov1CSvkQyvhEhNMs8Z5Mmk=
2+
github.com/cloudevents/sdk-go/v2 v2.6.1/go.mod h1:nlXhgFkf0uTopxmRXalyMwS2LG70cRGPrxzmjJgSG0U=
3+
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
4+
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
5+
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
6+
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
7+
github.com/google/go-cmp v0.5.0 h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=
8+
github.com/google/go-cmp v0.5.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
9+
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
10+
github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
111
github.com/google/uuid v1.2.0 h1:qJYtXnJRWmpe7m/3XlyhrsLrEURqHRM2kxzoxXqyUDs=
212
github.com/google/uuid v1.2.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
13+
github.com/json-iterator/go v1.1.10 h1:Kz6Cvnvv2wGdaG/V8yMvfkmNiXq9Ya2KUv4rouJJr68=
14+
github.com/json-iterator/go v1.1.10/go.mod h1:KdQUCv79m/52Kvf8AW2vK1V8akMuk1QjK/uOdHXbAo4=
315
github.com/kelseyhightower/envconfig v1.4.0 h1:Im6hONhd3pLkfDFsbRgu68RDNkGF1r3dvMUtDTo2cv8=
416
github.com/kelseyhightower/envconfig v1.4.0/go.mod h1:cccZRl6mQpaq41TPp5QxidR+Sa3axMbJDNb//FQX6Gg=
17+
github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
18+
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
19+
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
20+
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
21+
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 h1:ZqeYNhU3OHLH3mGKHDcjJRFFRrJa6eAM5H+CtDdOsPc=
22+
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
23+
github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742 h1:Esafd1046DLDQ0W1YjYsBW+p8U2u7vzgW2SQVmlNazg=
24+
github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0=
25+
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWbfPhv4DMiApHyliiK5xCTNVSPiaAs=
26+
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno=
27+
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
28+
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
29+
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
30+
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
31+
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
32+
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
33+
github.com/stretchr/testify v1.5.1 h1:nOGnQDM7FYENwehXlg/kFVnos3rEvtKTjRvOWSzb6H4=
34+
github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
35+
github.com/valyala/bytebufferpool v1.0.0 h1:GqA5TC/0021Y/b9FG4Oi9Mr3q7XYx6KllzawFIhcdPw=
36+
github.com/valyala/bytebufferpool v1.0.0/go.mod h1:6bBcMArwyJ5K/AmCkWv1jt77kVWyCJ6HpOuEn7z0Csc=
37+
go.uber.org/atomic v1.4.0 h1:cxzIVoETapQEqDhQu3QfnvXAV4AlzcvUCxkVUFw3+EU=
38+
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
39+
go.uber.org/multierr v1.1.0 h1:HoEmRHQPVSqub6w2z2d2EOVs2fjyFRGyofhKuyDq0QI=
40+
go.uber.org/multierr v1.1.0/go.mod h1:wR5kodmAFQ0UK8QlbwjlSNy0Z68gJhDJUG5sjR94q/0=
41+
go.uber.org/zap v1.10.0 h1:ORx85nbTijNz8ljznvCMR1ZBIPKFn3jQrag10X2AsuM=
42+
go.uber.org/zap v1.10.0/go.mod h1:vwi/ZaCAaUcBkycHslxD9B2zi4UTXhF60s6SWpuDF0Q=
43+
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
44+
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
45+
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
46+
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
47+
gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f h1:BLraFXnmrev5lT+xlilqcH8XK9/i0At2xKjWk4p6zsU=
48+
gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
49+
gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
50+
gopkg.in/yaml.v2 v2.3.0 h1:clyUAQHOM3G0M3f5vQj7LuJrETvjVot3Z5el9nffUtU=
51+
gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=

pkg/converter/cloudevents/cloudevents.go

Lines changed: 22 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,13 @@ import (
2424
"strings"
2525
"time"
2626

27+
cloudevents "github.com/cloudevents/sdk-go/v2"
2728
"github.com/google/uuid"
2829
"github.com/kelseyhightower/envconfig"
2930
)
3031

3132
const contentType = "application/cloudevents+json"
3233

33-
type ceBinaryStructure struct {
34-
ID string `json:"id"`
35-
Type string `json:"type"`
36-
Source string `json:"source"`
37-
Specversion string `json:"specversion"`
38-
Time string `json:"time,omitempty"`
39-
Contenttype string `json:"datacontenttype,omitempty"`
40-
Data interface{} `json:"data,omitempty"`
41-
}
42-
4334
// CloudEvent is a data structure required to map KLR responses to cloudevents
4435
type CloudEvent struct {
4536
// FunctionResponseMode describes what data is returned from the function:
@@ -94,38 +85,37 @@ func (ce *CloudEvent) Response(data []byte) ([]byte, error) {
9485
body = string(data)
9586
}
9687

97-
b := ceBinaryStructure{
98-
ID: uuid.NewString(),
99-
Type: ce.Overrides.EventType,
100-
Time: time.Now().Format(time.RFC3339),
101-
Source: ce.Overrides.Source,
102-
Specversion: "1.0",
103-
Contenttype: contentType,
104-
Data: body,
105-
}
106-
return json.Marshal(b)
88+
event := cloudevents.NewEvent(cloudevents.VersionV1)
89+
event.SetID(uuid.NewString())
90+
event.SetType(ce.Overrides.EventType)
91+
event.SetTime(time.Now())
92+
event.SetSource(ce.Overrides.Source)
93+
event.SetData(contentType, body)
94+
return event.MarshalJSON()
10795
}
10896

10997
func (ce *CloudEvent) fillInContext(data []byte) ([]byte, error) {
110-
var response ceBinaryStructure
111-
if err := json.Unmarshal(data, &response); err != nil {
98+
var event map[string]interface{}
99+
if err := json.Unmarshal(data, &event); err != nil {
112100
return nil, fmt.Errorf("cannot unmarshal function response into binary CE: %w", err)
113101
}
114102

115-
if response.ID == "" {
116-
response.ID = uuid.NewString()
103+
if _, set := event["id"]; !set {
104+
event["id"] = uuid.NewString()
117105
}
118-
if response.Type == "" {
119-
response.Type = ce.Overrides.EventType
106+
if _, set := event["type"]; !set {
107+
event["type"] = ce.Overrides.EventType
120108
}
121-
if response.Source == "" {
122-
response.Source = ce.Overrides.Source
109+
if _, set := event["source"]; !set {
110+
event["source"] = ce.Overrides.Source
123111
}
124-
if response.Specversion == "" {
125-
response.Specversion = "1.0"
112+
if _, set := event["specversion"]; !set {
113+
event["specversion"] = cloudevents.VersionV1
126114
}
127-
128-
return json.Marshal(response)
115+
if _, set := event["time"]; !set {
116+
event["time"] = time.Now().Format(time.RFC3339)
117+
}
118+
return json.Marshal(event)
129119
}
130120

131121
func (ce *CloudEvent) Request(request []byte, headers http.Header) ([]byte, map[string]string, error) {

0 commit comments

Comments
 (0)