From 50bc5ae7e05e5395d98aa64207aba4a3e9945d00 Mon Sep 17 00:00:00 2001
From: Martin Hutchinson <mhutchinson@gmail.com>
Date: Wed, 13 Dec 2023 14:45:50 +0000
Subject: [PATCH] Don't embed build info (#180)

This information isn't useful and makes it hard to reproducibly build the same output. If it was still useful then we could add it to the manifest, but it isn't, and so it is being removed. The build epcoh that is merged into CI builds will also need consideration, but is a separate PR.
---
 Makefile               | 6 +-----
 trusted_applet/main.go | 5 ++---
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index 210fdd9..79111d4 100644
--- a/Makefile
+++ b/Makefile
@@ -12,12 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-BUILD_USER ?= $(shell whoami)
-BUILD_HOST ?= $(shell hostname)
-BUILD_DATE ?= $(shell /bin/date -u "+%Y-%m-%d %H:%M:%S")
 BUILD_EPOCH := $(shell /bin/date -u "+%s")
 BUILD_TAGS = linkramsize,linkramstart,disable_fr_auth,linkprintk,nostatfs
-BUILD = ${BUILD_USER}@${BUILD_HOST} on ${BUILD_DATE}
 REV = $(shell git rev-parse --short HEAD 2> /dev/null)
 GIT_SEMVER_TAG ?= $(shell (git describe --tags --exact-match --match 'v*.*.*' 2>/dev/null || git describe --match 'v*.*.*' --tags 2>/dev/null || git describe --tags 2>/dev/null || echo -n v0.0.${BUILD_EPOCH}+`git rev-parse HEAD`) | tail -c +2 )
 FT_BIN_URL ?= "http://$(shell hostname --fqdn):9944/artefacts/"
@@ -44,7 +40,7 @@ ARCH = "arm"
 
 GOFLAGS = -tags ${BUILD_TAGS} -trimpath \
         -ldflags "-T ${TEXT_START} -E ${ENTRY_POINT} -R 0x1000 \
-                  -X 'main.Build=${BUILD}' -X 'main.Revision=${REV}' -X 'main.Version=${GIT_SEMVER_TAG}' \
+                  -X 'main.Revision=${REV}' -X 'main.Version=${GIT_SEMVER_TAG}' \
                   -X 'main.RestDistributorBaseURL=${REST_DISTRIBUTOR_BASE_URL}' \
                   -X 'main.updateBinariesURL=${FT_BIN_URL}' \
                   -X 'main.updateLogURL=${FT_LOG_URL}' \
diff --git a/trusted_applet/main.go b/trusted_applet/main.go
index 83c1c93..c6a6e87 100644
--- a/trusted_applet/main.go
+++ b/trusted_applet/main.go
@@ -66,7 +66,6 @@ const (
 )
 
 var (
-	Build    string
 	Revision string
 	Version  string
 
@@ -96,9 +95,9 @@ func main() {
 	}
 	monitoring.SetMetricFactory(mf)
 
-	log.Printf("%s/%s (%s) • TEE user applet • %s %s",
+	log.Printf("%s/%s (%s) • TEE user applet • %s",
 		runtime.GOOS, runtime.GOARCH, runtime.Version(),
-		Revision, Build)
+		Revision)
 
 	// Verify if we are allowed to run on this unit by sending version
 	// information for rollback protection check.