Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply selected open-source library guidance #8

Closed
tpeczek opened this issue Jan 17, 2019 · 6 comments
Closed

Apply selected open-source library guidance #8

tpeczek opened this issue Jan 17, 2019 · 6 comments
Assignees
@tpeczek
Labels
High Task
Milestone
v2.0.0

Comments

@tpeczek
Copy link
Owner

tpeczek commented Jan 17, 2019 •
edited
Loading

Apply selected open-source library guidance:

  • Add a target for net461
  • Strong name the assembly
  • Replace PackageLicenseUrl with PackageLicenseExpression

[DEPENDS ON] tpeczek/Lib.Net.Http.EncryptedContentEncoding#8


Open-source library guidance: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/
@tpeczek tpeczek added the Task label Jan 17, 2019
@tpeczek tpeczek self-assigned this Jan 17, 2019
@tpeczek tpeczek added this to the v2.0.0 milestone Jan 17, 2019
@tpeczek tpeczek mentioned this issue Jan 17, 2019
Open
@tpeczek tpeczek added the High label Jan 17, 2019
@theLeftTenant
Copy link

theLeftTenant commented Jan 17, 2019 •
edited
Loading

I noticed that the strong naming issue was present in the other .Net WebPush-based libraries too, for instance. Seems like strong naming would make it accessible in a lot more projects.

@tpeczek
Copy link
Owner Author

tpeczek commented Jan 17, 2019

I'm hoping to get this done by Monday.

@theLeftTenant
Copy link

Great. Once you publish your changes to the NuGet package, I'll install and ensure the strong name stuff is resolved.

tpeczek added a commit that referenced this issue Jan 18, 2019
@tpeczek
Applied selected open-source library guidance (#8)
9e1cb60
@tpeczek
Copy link
Owner Author

tpeczek commented Jan 19, 2019

@theLeftTenant It's up on NuGet, you can test.

@theLeftTenant
Copy link

@tpeczek That did the trick!

@tpeczek tpeczek closed this as completed Jan 22, 2019
@tpeczek
Copy link
Owner Author

tpeczek commented Jan 22, 2019

Happy I could improve the experience for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpeczek tpeczek

Labels
High Task
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@tpeczek @theLeftTenant