Merge pull request #45 from tpapp/tp/cosmetic-fixes

cosmetic changes

Author: tpapp

src/generic.jl

@@ -1,8 +1,9 @@
 export dimension, transform, transform_and_logjac, transform_logdensity, inverse, inverse!,
     inverse_eltype, as, random_arg, random_value
 
-
-# log absolute Jacobian determinant
+####
+#### log absolute Jacobian determinant
+####
 
 """
 $(TYPEDEF)
@@ -47,8 +48,9 @@ logjac_zero(::LogJac, T::Type{<:Real}) = log(one(T))
 
 logjac_zero(::NoLogJac, _) = NOLOGJAC
 
-
-# general
+####
+#### general
+####
 
 """
 $(TYPEDEF)
@@ -163,8 +165,9 @@ as((a = asℝ₊, b = as𝕀)) # transform 2 real numbers a NamedTuple, with a >
 """
 function as end
 
-
-# vector transformations
+####
+#### vector transformations
+####
 
 """
 An `AbstractVector` of `<:Real` elements.

src/scalar.jl

@@ -26,8 +26,9 @@ inverse_eltype(t::ScalarTransform, y::T) where {T <: Real} = float(T)
 
 random_arg(t::ScalarTransform; kwargs...) = random_real(; kwargs...)
 
-
-# identity
+####
+#### identity
+####
 
 """
 $(TYPEDEF)
@@ -42,8 +43,9 @@ transform_and_logjac(::Identity, x::Real) = x, zero(x)
 
 inverse(::Identity, x::Real) = x
 
-
-# shifted exponential
+####
+#### shifted exponential
+####
 
 """
 $(TYPEDEF)
@@ -77,8 +79,9 @@ function inverse(t::ShiftedExp{D}, x::Real) where D
     end
 end
 
-
-# scaled and shifted logistic
+####
+#### scaled and shifted logistic
+####
 
 """
 $(TYPEDEF)
@@ -123,8 +126,9 @@ function inverse_and_logjac(t::ScaledShiftedLogistic, y)
     logit(z), logit_logjac(z) - log(t.scale)
 end
 
-
-# to_interval interface
+####
+#### to_interval interface
+####
 
 struct Infinity{ispositive}
     Infinity{T}() where T = (@argcheck T isa Bool; new{T}())

src/special_arrays.jl

@@ -1,5 +1,9 @@
 export UnitVector, CorrCholeskyFactor
 
+####
+#### building blocks
+####
+
 """
     (y, r, ℓ) = $SIGNATURES
 
@@ -24,7 +28,10 @@ Inverse of [`l2_remainder_transform`](@ref) in `x` and `y`.
 """
 @inline l2_remainder_inverse(y, r) = logit((y/√r+1)/2), r-abs2(y)
 
-
+####
+#### UnitVector
+####
+
 """
     UnitVector(n)
 
@@ -74,8 +81,9 @@ function inverse!(x::RealVector, t::UnitVector, y::RealVector)
     x
 end
 
-
-# correlation cholesky factor
+####
+#### correlation cholesky factor
+####
 
 """
     CorrCholeskyFactor(n)

test/runtests.jl

@@ -64,18 +64,22 @@ end
 end
 
 @testset "to unit vector" begin
-    U = UnitVector(3)
-    x = zeros(3)               # incorrect
-    @test_throws ArgumentError U(x)
-    @test_throws ArgumentError transform(U, x)
-    @test_throws ArgumentError transform_and_logjac(U, x)
-
-    for K in 1:10
-        t = UnitVector(K)
-        @test dimension(t) == K - 1
-        if K > 1
-            test_transformation(t, y -> sum(abs2, y) ≈ 1,
-                                vec_y = y -> y[1:(end-1)])
+    @testset "dimension checks" begin
+        U = UnitVector(3)
+        x = zeros(3)               # incorrect
+        @test_throws ArgumentError U(x)
+        @test_throws ArgumentError transform(U, x)
+        @test_throws ArgumentError transform_and_logjac(U, x)
+    end
+
+    @testset "consistency checks" begin
+        for K in 1:10
+            t = UnitVector(K)
+            @test dimension(t) == K - 1
+            if K > 1
+                test_transformation(t, y -> sum(abs2, y) ≈ 1,
+                                    vec_y = y -> y[1:(end-1)])
+            end
         end
     end
 end