refactor(clippy): fix warnings

Author: kpp

examples/Cargo.toml

@@ -12,7 +12,7 @@ tox_core = { version = "0.1.1", path = "../tox_core" }
 
 log = "0.4"
 futures = { version = "0.3", default-features = false, features = ["std", "async-await"] }
-env_logger = "0.7"
+env_logger = "0.8"
 hex = "0.4"
 failure = "0.1"
 

tox_core/Cargo.toml

@@ -30,7 +30,7 @@ get_if_addrs = "0.5"
 failure = "0.1"
 lru = "0.6"
 bitflags = "1.0"
-itertools = "0.9"
+itertools = "0.10"
 
 [dependencies.tokio]
 version = "1.0"

tox_core/src/lib.rs

@@ -9,7 +9,7 @@ Repo: https://github.com/tox-rs/tox
 #![forbid(unsafe_code)]
 #![doc(html_logo_url = "https://raw.githubusercontent.com/tox-rs/logo/master/logo.png")]
 // Remove it when it will be fixed in nom parser
-#![allow(clippy::redundant_closure)]
+#![allow(clippy::redundant_closure, clippy::result_unit_err)]
 
 #[macro_use]
 extern crate log;

tox_core/src/net_crypto/mod.rs

@@ -885,7 +885,7 @@ impl NetCrypto {
             connection.packets_received += 1;
             self.process_ready_lossless_packets(&mut connection.recv_array, connection.peer_real_pk).await
                 .map_err(|e| e.context(HandlePacketErrorKind::SendToLossless))?;
-        } else if packet_id >= PACKET_ID_LOSSY_RANGE_START && packet_id <= PACKET_ID_LOSSY_RANGE_END {
+        } else if (PACKET_ID_LOSSY_RANGE_START..=PACKET_ID_LOSSY_RANGE_END).contains(&packet_id) {
             // Update end index of received buffer ignoring the error - we still
             // want to handle this packet even if connection is too slow
             connection.recv_array.set_buffer_end(payload.packet_number).ok();

tox_core/src/onion/client/mod.rs

@@ -633,12 +633,12 @@ impl OnionClient {
     }
 
     /// Generic function for sending search and announce requests to close nodes.
-    async fn ping_close_nodes<'a>(
+    async fn ping_close_nodes(
         &self,
         close_nodes: &mut Kbucket<OnionNode>,
         paths_pool: &mut PathsPool,
         announce_requests: &mut RequestQueue<AnnounceRequestData>,
-        announce_packet_data: AnnouncePacketData<'a>,
+        announce_packet_data: AnnouncePacketData<'_>,
         friend_pk: Option<PublicKey>,
         interval: Option<Duration>
     ) -> Result<bool, mpsc::SendError> {

tox_crypto/src/lib.rs

@@ -1,5 +1,7 @@
 //! Functions for the core crypto.
 
+#![allow(clippy::result_unit_err)]
+
 pub use sodiumoxide::randombytes::randombytes_into;
 pub use sodiumoxide::crypto::box_::*;
 pub use sodiumoxide::crypto::hash::{sha256, sha512};

tox_encryptsave/src/lib.rs

@@ -102,8 +102,8 @@ impl PassKey {
 
     ## Fails when:
 
-      * passphrase is empty
-      * deriving key failed (can happen due to OOM)
+    * passphrase is empty
+    * deriving key failed (can happen due to OOM)
 
     E.g.
 

tox_packet/src/onion/onion_announce_response.rs

@@ -140,7 +140,7 @@ impl FromBytes for OnionAnnounceResponsePayload {
         announce_status: call!(AnnounceStatus::from_bytes) >>
         ping_id_or_pk: call!(sha256::Digest::from_bytes) >>
         nodes: many0!(PackedNode::from_bytes) >>
-        _len: verify!(value!(nodes.len()), |len| *len <= 4 as usize) >>
+        _len: verify!(value!(nodes.len()), |len| *len <= 4_usize) >>
         eof!() >>
         (OnionAnnounceResponsePayload {
             announce_status,