Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgnp: more integration tests #14

Open
2 of 5 tasks
hawkw opened this issue Nov 2, 2023 · 0 comments
Open
2 of 5 tasks

mgnp: more integration tests #14

hawkw opened this issue Nov 2, 2023 · 0 comments
Milestone
MGNP v0.1

Comments

@hawkw
Copy link
Contributor

hawkw commented Nov 2, 2023 •
edited
Loading

PR #2 added basically one very simple happy-path integration test, where a peer connects to a single service on a remote peer and exchanges a single request/response pair. this doesn't exercise a bunch of the protocol, including potential edge cases.

some other stuff we definitely need to test includes:

  • multiple connections to the same service
  • multiple connections to different services
  • closing a connection and opening a new one (exercising stuff like ID reuse)
  • connections reset correctly on closes
  • handshake errors (but this isn't actually implemented at all, see mgnp: finish local connection establishment handshakes #12...)
@hawkw hawkw added this to the MGNP v0.1 milestone Nov 2, 2023
@hawkw hawkw mentioned this issue Nov 10, 2023
Merged
hawkw added a commit that referenced this issue Nov 10, 2023
@hawkw
feat(mgnp): add handshaking, redo outbound frame API (#21)
87dc51d 
This branch implements a bunch more of the MGNP protocol, including
`Hello` messages for connection establishment (see #12). In addition,
I've redone the frame types, including a much more usable
`OutboundFrame` API for the `Wire` implementation, which should be much
easier to serialize (see #13).

Furthermore, I've added a bunch more tests (see #14).

Closes #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MGNP v0.1
Development

No branches or pull requests
1 participant
@hawkw