New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements w7_defects/crystalline_defects #152

Open

basnijholt opened this issue Mar 22, 2016 · 1 comment

Member

basnijholt commented Mar 22, 2016

sorting_mid argument is not used in get_densities
box is missing in density plots, compare with edx_2015
create_edge_dislocation_system and create_screw_system can be combined and would simplify the plotting

The text was updated successfully, but these errors were encountered:

basnijholt mentioned this issue

Static plot recalculated in HoloMaps in w7_defects/crystalline_defects.ipynb #148

Closed

Member Author

basnijholt commented Mar 22, 2016

Also awkward way of generating parameters:

    parameters = {
        'BHZ': {'A': 1.0, 'B': 1.0, 'D': 0.0, 'M': 0.8},
        'QAH': {'A': 1.0, 'B': 1.0, 'D': 0.0, 'mu': 0.8}}

    p_BHZ = SimpleNamespace(field=.005, t_inter=-.1, **parameters['BHZ'])
    p_QAH = SimpleNamespace(field=.01, t_inter=-.1, **parameters['QAH'])

Doesn't make sense, since 'BHZ' and 'QAH' have most parameters shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment