fix access checks

ThomasKranitsas · ThomasKranitsas · commit aa801b0362aa · 2022-06-23T12:49:45.000+03:00
diff --git a/src/containers/ChallengeEditor/index.js b/src/containers/ChallengeEditor/index.js
@@ -175,17 +175,14 @@ class ChallengeEditor extends Component {
     if (isAdmin) {
       return true
     }
-    if (!hasProjectAccess) {
-      return false
-    }
     const userRoles = _.filter(
       challengeResources,
       cr => cr.memberId === `${loggedInUser.userId}`
     )
     const userResourceRoles = _.filter(resourceRoles, rr =>
       _.some(userRoles, ur => ur.roleId === rr.id)
     )
-    return _.some(
+    return hasProjectAccess || _.some(
       userResourceRoles,
       urr => urr.fullWriteAccess && urr.isActive
     )

Original file line number	Diff line number	Diff line change
`@@ -175,17 +175,14 @@ class ChallengeEditor extends Component {`
`175`	`175`	`if (isAdmin) {`
`176`	`176`	`return true`
`177`	`177`	`}`
`178`		`- if (!hasProjectAccess) {`
`179`		`- return false`
`180`		`- }`
`181`	`178`	`const userRoles = _.filter(`
`182`	`179`	`challengeResources,`
`183`	`180`	cr => cr.memberId === `${loggedInUser.userId}`
`184`	`181`	`)`
`185`	`182`	`const userResourceRoles = _.filter(resourceRoles, rr =>`
`186`	`183`	`_.some(userRoles, ur => ur.roleId === rr.id)`
`187`	`184`	`)`
`188`		`- return _.some(`
	`185`	`+ return hasProjectAccess \|\| _.some(`
`189`	`186`	`userResourceRoles,`
`190`	`187`	`urr => urr.fullWriteAccess && urr.isActive`
`191`	`188`	`)`