Merge pull request #83 from topcoder-platform/hotfix/null_pointer_in_logging

vikasrohit · web-flow · commit 86447aef78a7 · 2019-01-21T11:32:17.000+05:30
fixed null pointer in logging missing user email logs
diff --git a/connect/notificationServices/email.js b/connect/notificationServices/email.js
@@ -205,7 +205,7 @@ function handler(topicName, messageJSON, notification) {
     const user = users && users.length > 0 ? users[0] : null;
     let userEmail = _.get(user, 'email');
     if (!userEmail) {
-      logger.error(`Email not received for user: ${user.id}`);
+      logger.error(`Email not received for user: ${notification.userId}`);
       return;
     }
     const userStatus = _.get(user, 'status');

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ function handler(topicName, messageJSON, notification) {`
`205`	`205`	`const user = users && users.length > 0 ? users[0] : null;`
`206`	`206`	`let userEmail = _.get(user, 'email');`
`207`	`207`	`if (!userEmail) {`
`208`		- logger.error(`Email not received for user: ${user.id}`);
	`208`	+ logger.error(`Email not received for user: ${notification.userId}`);
`209`	`209`	`return;`
`210`	`210`	`}`
`211`	`211`	`const userStatus = _.get(user, 'status');`