Hotfix/skip user validation for project created event (#48)

* Removed customer user validation for generating the project created event

* Passed additional first name and last name along with project events as well

Author: vikasrohit

consumer/src/services/ConsumerService.js

@@ -9,7 +9,6 @@ import IdentityService from './IdentityService';
 import SalesforceService from './SalesforceService';
 import {UnprocessableError} from '../common/errors';
 
-const memberRole = 'customer';
 const duplicateRecordRegex = /TC_Connect_Project_Id__c duplicates value on record/;
 
 const projectCreatedSchema = Joi.object().keys({
@@ -40,18 +39,15 @@ class ConsumerService {
   @log(['project'])
   @validate(['logger','project'], projectCreatedSchema)
   processProjectCreated(logger, project) {
-    const member = _.find(project.members, {role: memberRole, isPrimary: true});
-    if (!member) {
-      logger.info('Project Members:');
-      logger.info(project.members);
-      throw new UnprocessableError('Cannot find primary customer');
-    }
+    logger.info(`Project Created By: ${project.createdBy}`);
     return Promise.all([
-      IdentityService.getUser(member.userId),
+      IdentityService.getUser(project.createdBy),
       SalesforceService.authenticate(),
     ]).then((responses) => {
       const user = responses[0];
       project.createdByEmail = user.email;
+      project.createdByFirstName = user.firstName;
+      project.createdByLastName = user.lastName;
       const { accessToken, instanceUrl } = responses[1];
       const leadData = {
         Type__c: 'connect.project.created',
@@ -80,7 +76,6 @@ class ConsumerService {
   @log(['projectEvent'])
   @validate(['logger', 'projectEvent'], projectUpdatedSchema)
   processProjectUpdated(logger, projectEvent) {
-    logger.debug(projectEvent)
     delete projectEvent.original.template;
     delete projectEvent.updated.template;
     var project = projectEvent.original;
@@ -93,6 +88,8 @@ class ConsumerService {
       const user = responses[0];
       const { accessToken, instanceUrl } = responses[1];
       projectEvent.original.createdByEmail = user.email;
+      projectEvent.original.createdByFirstName = user.firstName;
+      projectEvent.original.createdByLastName = user.lastName;
 
       const leadData = {
         Type__c: 'connect.project.updated',

consumer/test/ConsumerService.spec.js

@@ -51,13 +51,12 @@ describe('ConsumerService', () => {
         isPrimary: true,
       },
     ],
-    createdByEmail : "[email protected]"
+    createdBy: userId
   };
   const projectUpdatePaylod = {
     original: {
       id: 1,
-      status: 'in_review',
-      createdByEmail : "[email protected]"
+      status: 'in_review'
     },
     updated: {
       id: 1,
@@ -84,7 +83,12 @@ describe('ConsumerService', () => {
     it('should process project successfully', async() => {
       const expectedLead = {
         Type__c: 'connect.project.created',
-        Json__c: JSON.stringify(project)
+        Json__c: JSON.stringify({
+          ...project,
+          createdByEmail : user.email,
+          createdByFirstName: user.firstName,
+          createdByLastName: user.lastName
+        })
       };
 
       const createObjectStub = sandbox.stub(SalesforceService, 'createObject', async() => leadId);
@@ -95,19 +99,27 @@ describe('ConsumerService', () => {
       createObjectStub.should.have.been.calledWith('Connect_Event__c', expectedLead, sfAuth.accessToken, sfAuth.instanceUrl);
     });
 
-    it('should throw UnprocessableError primary customer is not found', async() => {
+    it('should NOT throw any error even if primary customer is not found', async() => {
       const projectWihoutMembers = {
-        id: 1,
-        members: [],
+        ...project,
+        members : []
       };
-      try {
-        ConsumerService.processProjectCreated(logger, projectWihoutMembers);
-        sinon.fail('Should be rejected');
-      } catch(err) {
-        expect(err).to.exist
-          .and.be.instanceof(UnprocessableError)
-          .and.have.property('message').and.match(/Cannot find primary customer/);
-      }
+      const expectedLead = {
+        Type__c: 'connect.project.created',
+        Json__c: JSON.stringify({
+          ...projectWihoutMembers,
+          createdByEmail : user.email,
+          createdByFirstName: user.firstName,
+          createdByLastName: user.lastName
+        })
+      };
+
+      const createObjectStub = sandbox.stub(SalesforceService, 'createObject', async() => leadId);
+
+      await ConsumerService.processProjectCreated(logger, projectWihoutMembers);
+      getUserStub.should.have.been.calledWith(userId);
+      authenticateStub.should.have.been.called;
+      createObjectStub.should.have.been.calledWith('Connect_Event__c', expectedLead, sfAuth.accessToken, sfAuth.instanceUrl);
     });
 
     it('should rethrow Error from createObject if error is not duplicate', async() => {
@@ -128,7 +140,15 @@ describe('ConsumerService', () => {
       const memberId = 'member-id';
       const expectedLead = {
         Type__c: 'connect.project.updated',
-        Json__c: JSON.stringify(projectUpdatePaylod)
+        Json__c: JSON.stringify({
+          original: {
+            ...projectUpdatePaylod.original,
+            createdByEmail : user.email,
+            createdByFirstName: user.firstName,
+            createdByLastName: user.lastName
+          },
+          updated: projectUpdatePaylod.updated
+        })
       };
       const createObjectStub = sandbox.stub(SalesforceService,'createObject', async() => {});