fixed the issue with the internal artifact download

Author: Dushyant Bhalgami

src/services/ArtifactService.js

@@ -46,7 +46,12 @@ function * downloadArtifact (submissionId, fileName) {
   if (artifacts.Contents.length === 0) {
     throw new errors.HttpStatusError(400, `Artifact ${fileName} doesn't exist for ${submissionId}`)
   }
-  const key = artifacts.Contents[0].Key
+
+  const key = submissionId + '/' + fileName + '.zip'
+  if (!_.includes(_.map(artifacts.Contents, 'Key'), key)) {
+    throw new errors.HttpStatusError(400, `Artifact ${fileName} doesn't exist for ${submissionId}`)
+  }
+
   const downloadedFile = yield s3.getObject({ Bucket: config.aws.ARTIFACT_BUCKET, Key: key }).promise()
   // Return the retrieved Artifact
   logger.info(`downloadArtifact: returning artifact ${fileName} for Submission ID: ${submissionId}`)
@@ -90,20 +95,7 @@ function * createArtifact (files, submissionId, entity) {
   if (files && files.artifact) {
     const uFileType = fileTypeFinder(files.artifact.data).ext // File type of uploaded file
     fileName = `${submissionId}/${files.artifact.name}.${uFileType}`
-    let exist
-    // Check the existence of file in S3 bucket
-    try {
-      exist = yield s3.headObject({
-        Bucket: config.aws.ARTIFACT_BUCKET,
-        Key: fileName
-      }).promise()
-    } catch (err) {
-      if (err.statusCode !== 404) throw err
-    }
 
-    if (exist) {
-      throw new errors.HttpStatusError(409, `Artifact ${files.artifact.name}.${uFileType} already exists for Submission ${submissionId}`)
-    }
     // Upload the artifact to S3
     yield _uploadToS3(files.artifact, fileName)
   } else {