Merge pull request #53 from marioskranitsas/fix-issue--39

rootelement · web-flow · commit a1e5cc67464c · 2020-12-19T10:37:16.000-05:00
fix error code when deleting resources
diff --git a/src/services/ResourceService.js b/src/services/ResourceService.js
@@ -385,7 +385,7 @@ async function deleteResource (currentUser, resource) {
       undefined)
 
     if (!ret) {
-      throw new errors.BadRequestError(`User ${handle || resource.memberHandle} doesn't have resource with roleId: ${resource.roleId} in challenge ${challengeId}`)
+      throw new errors.NotFoundError(`User ${handle || resource.memberHandle} doesn't have resource with roleId: ${resource.roleId} in challenge ${challengeId}`)
     }
 
     await ret.delete()

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ async function deleteResource (currentUser, resource) {`
`385`	`385`	`undefined)`
`386`	`386`
`387`	`387`	`if (!ret) {`
`388`		- throw new errors.BadRequestError(`User ${handle \|\| resource.memberHandle} doesn't have resource with roleId: ${resource.roleId} in challenge ${challengeId}`)
	`388`	+ throw new errors.NotFoundError(`User ${handle \|\| resource.memberHandle} doesn't have resource with roleId: ${resource.roleId} in challenge ${challengeId}`)
`389`	`389`	`}`
`390`	`390`
`391`	`391`	`await ret.delete()`