fix checks for self service

Author: ThomasKranitsas

src/services/ResourceService.js

@@ -255,10 +255,12 @@ async function init (currentUser, challengeId, resource, isCreated) {
   if (!currentUser.isMachine && !helper.hasAdminRole(currentUser)) {
     // Check if user has agreed to the challenge terms
     resources = await helper.query('Resource', { challengeId })
-    if (!(resourceRole.selfObtainable && _.get(challenge, 'legacy.selfService')) || _.toString(memberId) !== _.toString(currentUser.userId)) {
-      // if user is not creating/deleting a self obtainable resource for itself
-      // we need to perform check access first
-      await checkAccess(currentUser, resources)
+    if (!_.get(challenge, 'legacy.selfService')) {
+      if (resourceRole.selfObtainable || _.toString(memberId) !== _.toString(currentUser.userId)) {
+        // if user is not creating/deleting a self obtainable resource for itself
+        // we need to perform check access first
+        await checkAccess(currentUser, resources)
+      }
     }
   } else {
     // fetch resources for specified challenge and member