Skip to content

Commit 0dabd0b

Browse files
committed
Merge branch 'develop'
2 parents b673cb2 + e4ad10a commit 0dabd0b

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/services/ResourceService.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ async function init (currentUser, challengeId, resource, isCreated) {
223223
// Prevent from creating more than 1 submitter resources on tasks
224224
if (_.get(challenge, 'task.isTask', false) && isCreated && resource.roleId === config.SUBMITTER_RESOURCE_ROLE_ID) {
225225
const existing = await getResources(currentUser, challengeId, config.SUBMITTER_RESOURCE_ROLE_ID, 1, 1)
226-
if (existing.total > 0) {
226+
if (_.find(existing.data, r => r.roleId === config.SUBMITTER_RESOURCE_ROLE_ID)) {
227227
throw new errors.ConflictError(`The Task is already assigned`)
228228
}
229229
}
@@ -254,6 +254,10 @@ async function init (currentUser, challengeId, resource, isCreated) {
254254
range: { memberId: { eq: memberId } }
255255
})
256256
}
257+
// skip phase dependency checks for tasks
258+
if (_.get(challenge, 'task.isTask', false)) {
259+
return { resources, memberId, handle }
260+
}
257261
// check phases dependencies
258262
const dependencies = await ResourceRolePhaseDependencyService.getDependencies({ resourceRoleId: resource.roleId })
259263
_.forEach(dependencies, (dependency) => {
@@ -323,8 +327,7 @@ async function createResource (currentUser, resource) {
323327
refresh: 'true' // refresh ES so that it is visible for read operations instantly
324328
})
325329

326-
// console.log('Created resource:', ret)
327-
330+
logger.debug(`Created resource: ${JSON.stringify(_.pick(ret, payloadFields))}`)
328331
await helper.postEvent(config.RESOURCE_CREATE_TOPIC, _.pick(ret, payloadFields))
329332

330333
return ret
@@ -377,6 +380,7 @@ async function deleteResource (currentUser, resource) {
377380
refresh: 'true' // refresh ES so that it is effective for read operations instantly
378381
})
379382

383+
logger.debug(`Deleted resource, posting to Bus API: ${JSON.stringify(_.pick(ret, payloadFields))}`)
380384
await helper.postEvent(config.RESOURCE_DELETE_TOPIC, _.pick(ret, payloadFields))
381385
return ret
382386
} catch (err) {

0 commit comments

Comments
 (0)