@@ -223,7 +223,7 @@ async function init (currentUser, challengeId, resource, isCreated) {
223
223
// Prevent from creating more than 1 submitter resources on tasks
224
224
if ( _ . get ( challenge , 'task.isTask' , false ) && isCreated && resource . roleId === config . SUBMITTER_RESOURCE_ROLE_ID ) {
225
225
const existing = await getResources ( currentUser , challengeId , config . SUBMITTER_RESOURCE_ROLE_ID , 1 , 1 )
226
- if ( existing . total > 0 ) {
226
+ if ( _ . find ( existing . data , r => r . roleId === config . SUBMITTER_RESOURCE_ROLE_ID ) ) {
227
227
throw new errors . ConflictError ( `The Task is already assigned` )
228
228
}
229
229
}
@@ -254,6 +254,10 @@ async function init (currentUser, challengeId, resource, isCreated) {
254
254
range : { memberId : { eq : memberId } }
255
255
} )
256
256
}
257
+ // skip phase dependency checks for tasks
258
+ if ( _ . get ( challenge , 'task.isTask' , false ) ) {
259
+ return { resources, memberId, handle }
260
+ }
257
261
// check phases dependencies
258
262
const dependencies = await ResourceRolePhaseDependencyService . getDependencies ( { resourceRoleId : resource . roleId } )
259
263
_ . forEach ( dependencies , ( dependency ) => {
@@ -323,8 +327,7 @@ async function createResource (currentUser, resource) {
323
327
refresh : 'true' // refresh ES so that it is visible for read operations instantly
324
328
} )
325
329
326
- // console.log('Created resource:', ret)
327
-
330
+ logger . debug ( `Created resource: ${ JSON . stringify ( _ . pick ( ret , payloadFields ) ) } ` )
328
331
await helper . postEvent ( config . RESOURCE_CREATE_TOPIC , _ . pick ( ret , payloadFields ) )
329
332
330
333
return ret
@@ -377,6 +380,7 @@ async function deleteResource (currentUser, resource) {
377
380
refresh : 'true' // refresh ES so that it is effective for read operations instantly
378
381
} )
379
382
383
+ logger . debug ( `Deleted resource, posting to Bus API: ${ JSON . stringify ( _ . pick ( ret , payloadFields ) ) } ` )
380
384
await helper . postEvent ( config . RESOURCE_DELETE_TOPIC , _ . pick ( ret , payloadFields ) )
381
385
return ret
382
386
} catch ( err ) {
0 commit comments