avoid unnecessary call

Author: roger

src/services/ResourceService.js

@@ -244,10 +244,12 @@ async function init (currentUser, challengeId, resource, isCreated) {
   const memberId = await helper.getMemberIdByHandle(resource.memberHandle)
 
   // check if the resource is reviewer role and has already made a submission in the challenge
-  const submissionsRes = await helper.getRequest(`${config.SUBMISSIONS_API_URL}`, { challengeId: challengeId, perPage: 100, memberId: memberId })
-  const submissions = submissionsRes.body
-  if (submissions.length !== 0 && (resource.roleId === config.REVIEWER_RESOURCE_ROLE_ID || resource.roleId === config.ITERATIVE_REVIEWER_RESOURCE_ROLE_ID)) {
-    throw new errors.ConflictError(`The member has already submitted to the challenge and cannot have a Reviewer or Iterative Reviewer role`)
+  if (resource.roleId === config.REVIEWER_RESOURCE_ROLE_ID || resource.roleId === config.ITERATIVE_REVIEWER_RESOURCE_ROLE_ID) {
+    const submissionsRes = await helper.getRequest(`${config.SUBMISSIONS_API_URL}`, { challengeId: challengeId, perPage: 100, memberId: memberId })
+    const submissions = submissionsRes.body
+    if (submissions.length !== 0) {
+      throw new errors.ConflictError(`The member has already submitted to the challenge and cannot have a Reviewer or Iterative Reviewer role`)
+    }
   }
 
   // ensure resource role existed