Skip to content

Commit 04232c7

Browse files
committed
TCA-1195 - make the url for HiringManager preview public
1 parent bf9553a commit 04232c7

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

src-ts/tools/learn/learn-lib/hiring-manager-view/HiringManagerView.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ function renderBasicList(items: Array<string> = []): ReactNode {
5050
</ul>
5151
)
5252
}
53-
5453
export interface HiringManagerViewProps {
5554
certification?: TCACertification
5655
completedAt?: string
@@ -301,7 +300,7 @@ const HiringManagerView: FC<HiringManagerViewProps> = (props: HiringManagerViewP
301300
<Button
302301
buttonStyle='secondary'
303302
label={props.isOwner ? 'View your Topcoder profile' : 'View full Topcoder profile'}
304-
url={myProfileLink}
303+
url={props.isPreview ? '' : myProfileLink}
305304
target='_blank'
306305
className={styles.shareBtn}
307306
/>

src-ts/tools/learn/tca-certificate/user-certification-view/UserCertificationPreview.tsx

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { FC, useContext, useLayoutEffect } from 'react'
2-
import { NavigateFunction, Params, useNavigate, useParams } from 'react-router-dom'
1+
import { FC } from 'react'
2+
import { Params, useParams } from 'react-router-dom'
33

4-
import { LoadingSpinner, profileContext, ProfileContextData, UserProfile } from '../../../../lib'
4+
import { LoadingSpinner, UserProfile } from '../../../../lib'
55
import {
66
TCACertificationEnrollmentBase,
77
TCACertificationProviderData,
@@ -18,31 +18,23 @@ const placeholderUserProfile: UserProfile = {
1818

1919
const placeholderEnrollment: TCACertificationEnrollmentBase = {
2020
completedAt: new Date().toISOString(),
21-
completionUuid: 'test-uuid',
21+
completionUuid: 'certificate-number',
2222
userHandle: 'your_handle',
2323
userName: 'Your Name',
2424
} as TCACertificationEnrollmentBase
2525

2626
const UserCertificationPreview: FC<{}> = () => {
27-
const { profile, initialized: profileReady }: ProfileContextData = useContext(profileContext)
28-
const navigate: NavigateFunction = useNavigate()
29-
3027
const routeParams: Params<string> = useParams()
3128

3229
const {
3330
certification,
31+
ready,
3432
}: TCACertificationProviderData
3533
= useGetTCACertification(`${routeParams.certification}`)
3634

37-
useLayoutEffect(() => {
38-
if (profileReady && !profile) {
39-
navigate('..')
40-
}
41-
}, [navigate, profile, profileReady])
42-
4335
return (
4436
<>
45-
<LoadingSpinner hide={profileReady} />
37+
<LoadingSpinner hide={ready} />
4638

4739
<UserCertificationViewBase
4840
enrollment={placeholderEnrollment}

0 commit comments

Comments
 (0)