Skip to content

Users API defects #9

@morehappiness

Description

@morehappiness
  1. For all APIs, it uses checkPermission to check permission. We should make sure it considers the allowedScope when it's machine and follow the permission-checking logic in v3 java code.
  2. For DELETE :userId/SSOUserLogin, should not pass ssoUserId parameter and should follow the exist logic in v3 java as https://github.com/appirio-tech/identity-service/blob/bf2428ea6997e115b317eb419c5e2c1c6029cdf5/src/main/java/com/appirio/tech/core/service/identity/resource/UserResource.java#L300;
  3. For findUsers method, the logic should be same as v3 java code. Currently, the logic is deviated from v3 java code a lot.
  4. For registerUser method, validate logic is not right, such as validate password is not performed, validate handle, email logic is not consistent with java code; make sure the logic is consistent with v3 java code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions