Skip to content

Roles endpoint defects #8

@morehappiness

Description

@morehappiness

compared with v3 java code, the following are missing for roles endpoint:
1, get roles, and get role by id, should check auth user is machine or not and check scope if it's machine;
2, get roles, should return specified fields according to selector parameter;
3, assign role, and deassign role should call dao.checkRole as in the java code, see https://github.com/appirio-tech/identity-service/blob/bf2428ea6997e115b317eb419c5e2c1c6029cdf5/src/main/java/com/appirio/tech/core/service/identity/resource/RoleResource.java#L429;
4, hasRole, the logic should call dao.checkRole;
5, should we return role or role id from assigning or deassign role?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions