Merge pull request #361 from topcoder-platform/support-multiple-attachments

Support creating multiple attachments

Author: rootelement

docs/swagger.yaml

@@ -2095,7 +2095,7 @@ paths:
       tags:
         - Attachments
       description: >
-        Create a new attachment in the system.
+        Create a new attachment in the system. If you want to create multiple attachment, you can pass an array of objects instead of a single object.
       security:
         - bearer: []
       produces:

src/controllers/AttachmentController.js

@@ -2,6 +2,7 @@
  * Controller for attachment endpoints
  */
 const HttpStatus = require('http-status-codes')
+const _ = require('lodash')
 const service = require('../services/AttachmentService')
 
 /**
@@ -10,7 +11,8 @@ const service = require('../services/AttachmentService')
  * @param {Object} res the response
  */
 async function createAttachment (req, res) {
-  const result = await service.createAttachment(req.authUser, req.params.challengeId, req.body)
+  const body = _.isArray(req.body) ? req.body : [req.body]
+  const result = await service.createAttachment(req.authUser, req.params.challengeId, body)
   res.status(HttpStatus.CREATED).send(result)
 }
 

src/services/AttachmentService.js

@@ -52,36 +52,40 @@ async function _getChallengeAttachment (challengeId, attachmentId) {
 /**
  * Create attachment.
  * @param {String} challengeId the challenge id
- * @param {Object} attachment the attachment to created
+ * @param {Array} attachments the attachments to be created
  * @returns {Object} the created attachment
  */
-async function createAttachment (currentUser, challengeId, attachment) {
+async function createAttachment (currentUser, challengeId, attachments) {
   const challenge = await helper.getById('Challenge', challengeId)
   await helper.ensureUserCanModifyChallenge(currentUser, challenge)
-  validateUrl(attachment.url)
-  const attachmentObject = { id: uuid(), challengeId, ...attachment }
-  const ret = await helper.create('Attachment', attachmentObject)
+  const newAttachments = []
+  for (const attachment of attachments) {
+    validateUrl(attachment.url)
+    const attachmentObject = { id: uuid(), challengeId, ...attachment }
+    const newAttachment = await helper.create('Attachment', attachmentObject)
+    await helper.postBusEvent(constants.Topics.ChallengeAttachmentCreated, ret)
+    newAttachments.push(newAttachment)
+  }
   // update challenge object
   await challengeService.partiallyUpdateChallenge(currentUser, challengeId, {
     attachments: [
       ..._.get(challenge, 'attachments', []),
-      ret
+      ...newAttachments
     ]
   })
   // post bus event
-  await helper.postBusEvent(constants.Topics.ChallengeAttachmentCreated, ret)
-  return ret
+  return newAttachments
 }
 
 createAttachment.schema = {
   currentUser: Joi.any(),
   challengeId: Joi.id(),
-  attachment: Joi.object().keys({
+  attachments: Joi.array().items(Joi.object().keys({
     name: Joi.string().required(),
     url: Joi.string().uri().required(),
     fileSize: Joi.fileSize(),
     description: Joi.string()
-  }).required()
+  })).required().min(1)
 }
 
 /**