Better iterative review handling for TG Task

Author: jmgasper

src/autopilot/services/first2finish.service.spec.ts

@@ -188,6 +188,38 @@ describe('First2FinishService', () => {
     expect(schedulerService.advancePhase).not.toHaveBeenCalled();
   });
 
+  it('keeps the active iterative review phase open when no submissions are available', async () => {
+    const activePhase = buildIterativePhase({
+      isOpen: true,
+      actualEndDate: null,
+    });
+
+    const challenge = buildChallenge({
+      phases: [activePhase],
+      reviewers: [buildReviewer()],
+    });
+
+    challengeApiService.getChallengeById.mockResolvedValue(challenge);
+
+    resourcesService.getReviewerResources.mockResolvedValue([
+      {
+        id: 'resource-1',
+        memberId: '2001',
+        memberHandle: 'iterativeReviewer',
+        roleName: 'Iterative Reviewer',
+      },
+    ]);
+
+    reviewService.getAllSubmissionIdsOrdered.mockResolvedValue([]);
+    reviewService.getExistingReviewPairs.mockResolvedValue(new Set());
+
+    await service.handleSubmissionByChallengeId(challenge.id);
+
+    expect(reviewService.createPendingReview).not.toHaveBeenCalled();
+    expect(schedulerService.advancePhase).not.toHaveBeenCalled();
+    expect(schedulerService.schedulePhaseTransition).not.toHaveBeenCalled();
+  });
+
   it('reopens the seeded iterative review phase when the first submission arrives', async () => {
     const seedPhase = buildIterativePhase({
       isOpen: false,

src/autopilot/services/first2finish.service.ts

@@ -364,6 +364,20 @@ export class First2FinishService {
     );
 
     if (!assigned) {
+      const submissionSnapshot =
+        await this.reviewService.getAllSubmissionIdsOrdered(challenge.id);
+
+      if (!submissionSnapshot.length) {
+        this.logger.debug(
+          `No submissions available yet for iterative review on challenge ${challenge.id}; keeping phase ${activePhase.id} open.`,
+          {
+            submissionId: submissionId ?? null,
+            phaseId: activePhase.id,
+          },
+        );
+        return;
+      }
+
       this.logger.debug(
         `No additional submissions available for iterative review on challenge ${challenge.id}; closing phase ${activePhase.id}.`,
       );