Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit 5ccd262

Browse files
authored
Merge pull request #346 from deedee/mm_type
mm_type
2 parents 2a73680 + 94c69d6 commit 5ccd262

File tree

8 files changed

+72
-8
lines changed

8 files changed

+72
-8
lines changed

src/web/WEB-INF/includes/contest/editTabMarathon.jsp

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@
9696
<td class="sec_tab_type"><strong>: <span id="rProjectName"><c:out value="${sessionData.currentProjectContext.name}" /></span></strong></td>
9797
</tr>
9898
<tr></tr>
99+
<tr>
100+
<td class="first_tab_type"><strong>MM Type</strong></td>
101+
<td class="sec_tab_type"><strong>: <span id="rMMType"></span></strong></td>
102+
</tr>
103+
<tr></tr>
99104
<%--
100105
<tr>
101106
<td class="first_tab_type"><strong>Product</strong></td>
@@ -225,7 +230,20 @@
225230
</select>
226231
</div>
227232
</div>
228-
<br /><br /><br />
233+
<br /><br />
234+
235+
<div id="mmTypeEditDiv">
236+
<br />
237+
<span class="name fixWidthName"><strong>MM Type</strong></span>
238+
<div class="mmTypeSelect" style="float:left">
239+
<select id="mmType" name="mmType" class="bigin">
240+
<option value="0">Please select marathon match type</option>
241+
<option value="Classic">Classic</option>
242+
<option value="Banner">Banner</option>
243+
</select>
244+
</div>
245+
</div>
246+
<br /><br />
229247
<%--
230248
<span class="name fixWidthName"><strong>Product</strong></span>
231249
<span class="value">

src/web/WEB-INF/includes/launch/contestSelection.jsp

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,22 @@
135135
</div>
136136
</div>
137137

138+
<!-- MM Type -->
139+
<div class="row">
140+
<label>MM Type<span class="red">*</span> :</label>
141+
<div class="mmTypeSelect">
142+
<select id="mmType" name="mmType">
143+
<option value="0">Please select marathon match type</option>
144+
<option value="Classic">Classic</option>
145+
<option value="Banner">Banner</option>
146+
</select>
147+
</div>
148+
</div>
149+
150+
<div class="row" id="billingGroupCheckBox">
151+
&nbsp;&nbsp;&nbsp;<input type="checkbox" style=""><span>Run this challenge in a private community ? &nbsp;&nbsp;</span> <select id="billingGroups" name="billingGroups"></select>
152+
</div>
153+
138154
<!-- Billing Account -->
139155
<div class="row">
140156
<label>Billing Account :</label>

src/web/css/direct/launchcontest.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@
349349
border: 1px solid #a8abad;
350350
}
351351

352-
#launchContestOut .addNewContest .projectSelect, #launchContestOut .addNewContest .billingSelect, #launchContestOut .addNewContest .copilotSelect, .reviewScorecardSelect, .milestoneSelect, .reviewerSelect, .registrantsSelect {
352+
#launchContestOut .addNewContest .projectSelect, #launchContestOut .addNewContest .billingSelect, #launchContestOut .addNewContest .copilotSelect, .reviewScorecardSelect, .milestoneSelect, .reviewerSelect, .registrantsSelect, .mmTypeSelect{
353353
width: auto;
354354
float: left;
355355
display: inline;
@@ -1952,7 +1952,7 @@ a.draft:hover span.right, a.preview:hover span.right {
19521952
}
19531953

19541954
/** billing and round select **/
1955-
.reviewScorecardSelect .newListSelected, .billingSelect .newListSelected, .prizeBillingSelect .newListSelected, .roundelect .newListSelected, .copilotSelect .newListSelected, .milestoneSelect .newListSelected, .projectsSelect .newListSelected, .copilotsSelect .newListSelected, .problemSelect .newListSelected, .reviewerSelect .newListSelected, .registrantsSelect .newListSelected {
1955+
.reviewScorecardSelect .newListSelected, .billingSelect .newListSelected, .prizeBillingSelect .newListSelected, .roundelect .newListSelected, .copilotSelect .newListSelected, .milestoneSelect .newListSelected, .projectsSelect .newListSelected, .copilotsSelect .newListSelected, .problemSelect .newListSelected, .reviewerSelect .newListSelected, .registrantsSelect .newListSelected, .mmTypeSelect .newListSelected {
19561956
width: 283px;
19571957
height: 28px;
19581958
padding: 0 5px;
@@ -1969,11 +1969,11 @@ a.draft:hover span.right, a.preview:hover span.right {
19691969
color: #6c6c6c;
19701970
}
19711971

1972-
.reviewScorecardSelect .selectedTxt, .billingSelect .selectedTxt, .prizeBillingSelect .selectedTxt, .roundelect .selectedTxt, .copilotSelect .selectedTxt, .milestoneSelect .selectedTxt, .copilotsSelect .selectedTxt, .projectsSelect .selectedTxt, .problemSelect .selectedTxt, .reviewerSelect .selectedTxt, .registrantsSelect .selectedTxt {
1972+
.reviewScorecardSelect .selectedTxt, .billingSelect .selectedTxt, .prizeBillingSelect .selectedTxt, .roundelect .selectedTxt, .copilotSelect .selectedTxt, .milestoneSelect .selectedTxt, .copilotsSelect .selectedTxt, .projectsSelect .selectedTxt, .problemSelect .selectedTxt, .reviewerSelect .selectedTxt, .registrantsSelect .selectedTxt, .mmTypeSelect .selectedTxt {
19731973
width: 281px;
19741974
}
19751975

1976-
.reviewScorecardSelect .newList, .billingSelect .newList, .prizeBillingSelect .newList, .roundelect .newList, .copilotSelect .newList, .milestoneSelect .newList, .copilotsSelect .newList, .projectsSelect .newList, .problemSelect .newList, .reviewerSelect .newList, .registrantsSelect .newList{
1976+
.reviewScorecardSelect .newList, .billingSelect .newList, .prizeBillingSelect .newList, .roundelect .newList, .copilotSelect .newList, .milestoneSelect .newList, .copilotsSelect .newList, .projectsSelect .newList, .problemSelect .newList, .reviewerSelect .newList, .registrantsSelect .newList, .mmTypeSelect .newList{
19771977
width: 290px;
19781978
border: #ccc solid 1px;
19791979
background: #fff;

src/web/scripts/launch/contestDetailSoftware.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,6 +1389,11 @@ function populateTypeSection() {
13891389
$(".matchRoundId").show();
13901390
}
13911391

1392+
if (mainWidget.softwareCompetition.projectHeader.properties.hasOwnProperty(MM_TYPE)) {
1393+
$('#rMMType').text(mainWidget.softwareCompetition.projectHeader.properties[MM_TYPE]);
1394+
$('#mmType').getSetSSValue(mainWidget.softwareCompetition.projectHeader.properties[MM_TYPE]);
1395+
}
1396+
13921397
// populate review style
13931398
if (mainWidget.softwareCompetition.projectHeader.properties['Review Type'] && mainWidget.competitionType == "SOFTWARE") {
13941399
var reviewType = mainWidget.softwareCompetition.projectHeader.properties['Review Type'];
@@ -1524,6 +1529,9 @@ function validateFieldsTypeSection() {
15241529
&& categoryId != STUDIO_CATEGORY_ID_DESIGN_F2F) {
15251530
validateDirectProjectMilestone(milestoneId, errors);
15261531
}
1532+
if (categoryId == ALGORITHM_CATEGORY_ID_MARATHON && $('#mmType').val() === '0') {
1533+
errors.push('Marathon match type is required');
1534+
}
15271535
if (errors.length > 0) {
15281536
showErrors(errors);
15291537
return false;
@@ -1569,6 +1577,11 @@ function validateFieldsTypeSection() {
15691577
// set iterative review scorecard
15701578
mainWidget.softwareCompetition.projectHeader.reviewScorecardId = parseInt($('select#reviewScorecardSelects').val());
15711579
}
1580+
1581+
if (categoryId == ALGORITHM_CATEGORY_ID_MARATHON) {
1582+
mainWidget.softwareCompetition.projectHeader.properties[MM_TYPE] = $('#mmType').val().trim();
1583+
}
1584+
15721585
return true;
15731586
}
15741587

@@ -1627,6 +1640,11 @@ function showTypeSectionEdit() {
16271640
$('#reviewer').data('customized',true);
16281641
}
16291642

1643+
if(!$('#mmType').data('customized')) {
1644+
$('#mmType').sSelect({ddMaxHeight: '220',yscroll: true});
1645+
$('#mmType').data('customized',true);
1646+
}
1647+
16301648
$('#contestTypes').getSetSSValue(mainWidget.competitionType + mainWidget.softwareCompetition.projectHeader.projectCategory.id);
16311649

16321650
var projectType = mainWidget.competitionType;

src/web/scripts/launch/entity.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ var PRODUCT_SKU ="Product SKU";
203203

204204
var ENVIRONMENT = "Environment";
205205
var CODE_REPO = "Code Repo";
206+
var MM_TYPE = "Marathon Match Type";
206207

207208
var projectCategoryArray = [
208209
{id:SOFTWARE_CATEGORY_ID_CONCEPT, name:'CONCEPTUALIZATION', label:'Software Conceptualization', typeId:2, typeName:'Application', hasMulti:true, hideInDropdown: true},

src/web/scripts/launch/main.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,8 @@ function saveAsDraftRequestSoftware() {
12161216
mainWidget.softwareCompetition.projectHeader.properties['Thurgood Platform'] = '';
12171217
}
12181218

1219+
delete mainWidget.softwareCompetition.projectHeader.properties[MM_TYPE];
1220+
12191221
if(isF2F() || isCode()) {
12201222
// get the auto assign reviewer ID to F2F / CODE challenge
12211223
mainWidget.softwareCompetition.projectHeader.autoAssignReviewerId =
@@ -1321,6 +1323,8 @@ function saveAsDraftRequestStudio() {
13211323
request['directProjectMilestoneId'] = mainWidget.softwareCompetition.projectMilestoneId;
13221324
request['preRegisterUsers'] = mainWidget.softwareCompetition.preRegisterUsers;
13231325

1326+
delete mainWidget.softwareCompetition.projectHeader.properties[MM_TYPE];
1327+
13241328
if (!isNaN(mainWidget.softwareCompetition.copilotUserId)) {
13251329
request['contestCopilotId'] = mainWidget.softwareCompetition.copilotUserId;
13261330
request['contestCopilotName'] = mainWidget.softwareCompetition.copilotUserName;

src/web/scripts/launch/pages/selection.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,15 +150,18 @@ function validateFieldsContestSelectionAlgorithm() {
150150
var startDate = getDateByIdPrefix('start');
151151
var regEndDate = getDateByIdPrefix('regEnd');
152152
var endDate = getDateByIdPrefix('subEnd');
153-
153+
154154
//validation
155155
var errors = [];
156156

157157
//validate contest
158158
validateContestName(contestName, errors);
159159

160160
validateTcProject(tcProjectId, errors);
161-
161+
162+
if ($('#mmType').val() === '0') {
163+
errors.push('Marathon match type is required');
164+
}
162165
// validate schedule
163166
if(startDate >= regEndDate) {
164167
errors.push('The registration end date should be after the start date.');
@@ -196,6 +199,7 @@ function validateFieldsContestSelectionAlgorithm() {
196199

197200
mainWidget.softwareCompetition.subEndDate = endDate;
198201
mainWidget.softwareCompetition.regEndDate = regEndDate;
202+
mainWidget.softwareCompetition.projectHeader.properties[MM_TYPE] = $('#mmType').val().trim();
199203

200204
//prizes is on category id
201205
// fillPrizes();

src/web/scripts/launchcontest.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ $(document).ready(function() {
482482
ddMaxHeight: '220px',
483483
yscroll: true
484484
};
485-
$('.billingSelect select,.roundelect select,.startEtSelect select,.checkpointEtSelect select,.endEtSelect select').sSelect(SelectOptions);
485+
$('.billingSelect select,.roundelect select,.startEtSelect select,.checkpointEtSelect select,.endEtSelect select, .mmTypeSelect select').sSelect(SelectOptions);
486486
$('.projectSelect select').sSelect(SelectOptions).change(function() {
487487
handleProjectDropDownChange();
488488
});
@@ -884,12 +884,15 @@ function onContestTypeChange() {
884884
// show the end date for marathon match
885885
$("#subEndDateDiv").show();
886886
$("div.milestoneSelect").parents("div.row").hide();
887+
$("#mmType").closest(".row").show();
887888
} else if(contestType == 'SOFTWARE') {
888889
$("#subEndDateDiv").show();
889890
$("div.milestoneSelect").parents("div.row").show();
891+
$("#mmType").closest(".row").hide();
890892
} else {
891893
$("#subEndDateDiv").hide();
892894
$("div.milestoneSelect").parents("div.row").show();
895+
$("#mmType").closest(".row").hide();
893896
}
894897

895898
if (isContestSaved() && mainWidget.competitionType != contestType) {

0 commit comments

Comments
 (0)