fix: log response body on error (#165)

* fix: log response body on error

* fix: log response body on error when verbose is on

* fix: log response body on error when verbose is on

Author: stepan662

src/client/ApiClient.ts

@@ -4,7 +4,7 @@ import createClient, { ParseAs } from 'openapi-fetch';
 import base32Decode from 'base32-decode';
 import { API_KEY_PAK_PREFIX, USER_AGENT } from '../constants.js';
 import { getApiKeyInformation } from './getApiKeyInformation.js';
-import { debug } from '../utils/logger.js';
+import { debug, isDebugEnabled } from '../utils/logger.js';
 import { errorFromLoadable } from './errorFromLoadable.js';
 
 async function parseResponse(response: Response, parseAs: ParseAs) {
@@ -78,8 +78,18 @@ export function createApiClient({
       debug(`[HTTP] Requesting: ${request.method} ${request.url}`);
     },
     onResponse: async ({ response, options }) => {
-      debug(`[HTTP] Response: ${response.url} [${response.status}]`);
-
+      let responseText = `[HTTP] Response: ${response.url} [${response.status}]`;
+      const apiVersion = response.headers.get('x-tolgee-version');
+      if (apiVersion) {
+        responseText += ` [${response.headers.get('x-tolgee-version')}]`;
+      }
+      if (!response.ok && isDebugEnabled()) {
+        const clonedBody = await response.clone().text();
+        if (clonedBody) {
+          responseText += ` [${clonedBody}]`;
+        }
+      }
+      debug(responseText);
       if (autoThrow && !response.ok) {
         const loadable = await parseResponse(response, options.parseAs);
         throw new Error(

test/e2e/error.test.ts

@@ -0,0 +1,39 @@
+import { tmpdir } from 'os';
+import { join } from 'path';
+import { rm } from 'fs/promises';
+import { run } from './utils/run.js';
+import { TolgeeClient } from '#cli/client/TolgeeClient.js';
+import { PROJECT_1 } from './utils/api/project1.js';
+import { createProjectWithClient, deleteProject } from './utils/api/common.js';
+import { removeTmpFolder } from './utils/tmp.js';
+
+const AUTH_FILE_PATH = join(tmpdir(), '.tolgee-e2e', 'authentication.json');
+
+afterEach(async () => {
+  await removeTmpFolder();
+  try {
+    await rm(AUTH_FILE_PATH);
+  } catch (e: any) {
+    if (e.code !== 'ENOENT') {
+      throw e;
+    }
+  }
+});
+
+let client: TolgeeClient;
+
+describe('Testing error message', () => {
+  beforeAll(async () => {
+    client = await createProjectWithClient('Project 1', PROJECT_1);
+  });
+  afterAll(async () => {
+    await deleteProject(client);
+  });
+
+  it('error server response body is printed', async () => {
+    const out = await run(['login', 'tgpat_meow', '--verbose']);
+
+    expect(out.code).toBe(1);
+    expect(out.stdout).toMatch('"code":"invalid_pat"');
+  });
+});