Skip to content
This repository was archived by the owner on Dec 28, 2022. It is now read-only.

Commit 231d226

Browse files
author
Isabel Boos
committed
fix(app-extensions): create ENTITY_DOCS selection for legacy actions
- dms entites should handled as entity_docs selection for legacy actions Refs: TOCDEV-6314 Cherry-pick: Up Changelog: create ENTITY_DOCS selection for legacy actions
1 parent 799fec6 commit 231d226

File tree

2 files changed

+33
-1
lines changed

2 files changed

+33
-1
lines changed

packages/app-extensions/src/actions/modules/actionHandlers/legacyAction.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import remoteEvents from '../../../remoteEvents'
77
import rest from '../../../rest'
88

99
const ignoredExceptionMessages = ['Single selection only, aborting...', 'Nothing selected, aborting...']
10+
const entityDocsEntity = ['Folder', 'Resource']
1011

1112
export const loadScript = src =>
1213
new Promise((resolve, reject) => {
@@ -159,8 +160,9 @@ export function* getSelection(selection) {
159160
}
160161

161162
if (selection.type === 'ID') {
163+
const isEntityDocsEntity = entityDocsEntity.includes(selection.entityName)
162164
legacySelection.selectedEntities = selection.ids
163-
legacySelection.selectionType = 'SELECTION'
165+
legacySelection.selectionType = isEntityDocsEntity ? 'ENTITY_DOCS': 'SELECTION'
164166
} else if (selection.type === 'QUERY') {
165167
const listState = yield select(listSelector)
166168

packages/app-extensions/src/actions/modules/actionHandlers/legacyAction.spec.js

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,36 @@ describe('app-extensions', () => {
210210
.run()
211211
})
212212

213+
test('should use ENTITY_DOCS selection for Folder', () => {
214+
const selection = {
215+
entityName: 'Folder',
216+
type: 'ID',
217+
ids: ['5', '18', '3']
218+
}
219+
return expectSaga(legacyAction.getSelection, selection)
220+
.returns({
221+
entityName: 'Folder',
222+
selectionType: 'ENTITY_DOCS',
223+
selectedEntities: ['5', '18', '3']
224+
})
225+
.run()
226+
})
227+
228+
test('should use ENTITY_DOCS selection for Resource', () => {
229+
const selection = {
230+
entityName: 'Resource',
231+
type: 'ID',
232+
ids: ['5', '18', '3']
233+
}
234+
return expectSaga(legacyAction.getSelection, selection)
235+
.returns({
236+
entityName: 'Resource',
237+
selectionType: 'ENTITY_DOCS',
238+
selectedEntities: ['5', '18', '3']
239+
})
240+
.run()
241+
})
242+
213243
test('should return search params for QUERY selection', () => {
214244
const selection = {
215245
entityName: 'User',

0 commit comments

Comments
 (0)