Skip to content

add missing validation to notary's secret in the Attestation #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
themighty1 opened this issue Apr 11, 2025 · 0 comments · May be fixed by #792
Open

add missing validation to notary's secret in the Attestation #774

themighty1 opened this issue Apr 11, 2025 · 0 comments · May be fixed by #792
Assignees
Labels
bug Something isn't working
Milestone

Comments

@themighty1
Copy link
Member

Currently the prover is not performing validation in the Attestation of the Notary's secret used to derive the encodings.
Relevant code:

pub fn validate(&self, attestation: &Attestation) -> Result<(), InconsistentAttestation> {

This opens up an attack which will go like this:

  • the Notary flips an encoding of a single bit and sends the encodings to the Prover
  • the Prover commits (unknowingly) to the flipped encoding and gets an Attestation
  • later the Prover creates a presentation and sends it to an app-specific Verifier
  • the Verifier will fail or verify the encoding commitment
  • the Notary will observe the failure

at best, this would be a DoS attack against the Prover
additionally, the Notary will also learn whether a certain bit was opened to the Verifier or not

@themighty1 themighty1 added the bug Something isn't working label Apr 11, 2025
@sinui0 sinui0 added this to the alpha.11 milestone Apr 15, 2025
@themighty1 themighty1 linked a pull request Apr 21, 2025 that will close this issue
@themighty1 themighty1 linked a pull request Apr 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants