Skip to content

Commit 6f6b24e

Browse files
authored
test: fix failing tests (#823)
1 parent a287189 commit 6f6b24e

File tree

2 files changed

+25
-15
lines changed

2 files changed

+25
-15
lines changed

crates/core/src/connection.rs

+25-2
Original file line numberDiff line numberDiff line change
@@ -380,16 +380,39 @@ pub enum CertificateVerificationError {
380380
#[cfg(test)]
381381
mod tests {
382382
use super::*;
383-
use crate::{fixtures::ConnectionFixture, transcript::Transcript};
383+
use crate::{
384+
fixtures::ConnectionFixture, provider::default_cert_verifier, transcript::Transcript,
385+
};
384386

385387
use hex::FromHex;
386388
use rstest::*;
389+
use tls_core::verify::WebPkiVerifier;
387390
use tlsn_data_fixtures::http::{request::GET_WITH_HEADER, response::OK_JSON};
388391

389392
#[fixture]
390393
#[once]
391394
fn crypto_provider() -> CryptoProvider {
392-
CryptoProvider::default()
395+
let mut store = default_cert_verifier().root_store().clone();
396+
397+
// Add a cert which is no longer included in the Mozilla root store.
398+
let cert = tls_core::key::Certificate(
399+
appliedzkp()
400+
.server_cert_data
401+
.certs
402+
.last()
403+
.expect("chain is valid")
404+
.0
405+
.clone(),
406+
);
407+
408+
store.add(&cert).unwrap();
409+
410+
CryptoProvider {
411+
hash: Default::default(),
412+
cert: WebPkiVerifier::new(store, None),
413+
signer: Default::default(),
414+
signature: Default::default(),
415+
}
393416
}
394417

395418
fn tlsnotary() -> ConnectionFixture {

crates/tls/client/src/verifybench.rs

-13
Original file line numberDiff line numberDiff line change
@@ -55,19 +55,6 @@ fn test_arstechnica_cert() {
5555
.bench(100)
5656
}
5757

58-
#[test]
59-
fn test_servo_cert() {
60-
Context::new(
61-
"servo",
62-
"servo.org",
63-
&[
64-
include_bytes!("testdata/cert-servo.0.der"),
65-
include_bytes!("testdata/cert-servo.1.der"),
66-
],
67-
)
68-
.bench(100)
69-
}
70-
7158
#[test]
7259
fn test_twitter_cert() {
7360
Context::new(

0 commit comments

Comments
 (0)