Skip to content

Commit 154ba58

Browse files
authored
cleanup: update workflows, bump snap version (#285)
Signed-off-by: K.B.Dharun Krishna <[email protected]>
1 parent 0bdc78f commit 154ba58

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# This workflow will upload a Python Package using Trusted Publishers automatically when a release is created
1+
# This workflow will upload a Python Package using Trusted Publishers automatically when a release is created and the deployment is approved by an admin
22
# For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries
33
# and https://docs.pypi.org/trusted-publishers/using-a-publisher/.
44

.github/workflows/test.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ jobs:
4949
run: |
5050
python3 -m pip install .
5151
tldr --version
52-
tldr tldr --markdown
5352
5453
build-macos:
5554
runs-on: macos-latest
55+
needs: ['build-linux']
5656

5757
permissions:
5858
contents: read
@@ -97,10 +97,10 @@ jobs:
9797
run: |
9898
python3 -m pip install .
9999
tldr --version
100-
tldr tldr --markdown
101100
102101
build-windows:
103102
runs-on: windows-latest
103+
needs: ['build-macos']
104104

105105
permissions:
106106
contents: read
@@ -144,10 +144,10 @@ jobs:
144144
run: |
145145
python3 -m pip install .
146146
tldr --version
147-
tldr tldr --markdown
148147
149148
build-windows-arm:
150149
runs-on: windows-11-arm
150+
needs: ['build-windows']
151151

152152
permissions:
153153
contents: read
@@ -183,11 +183,10 @@ jobs:
183183
run: |
184184
python3 -m pip install .
185185
tldr --version
186-
tldr tldr --markdown
187186
188187
build-snap:
189188
runs-on: ${{ matrix.os }}
190-
if: github.repository == 'tldr-pages/tldr-python-client' && github.ref == 'refs/heads/main'
189+
if: github.repository == 'tldr-pages/tldr-python-client' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
191190
needs: ['build-linux']
192191

193192
permissions:

snap/snapcraft.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: tldr
22
base: core24
3-
version: '3.4.0'
3+
version: '3.4.1'
44
summary: tldr python client
55
description: Official Python command-line client for tldr pages.
66

0 commit comments

Comments
 (0)