Hook for powershell under windows #501
superjojo79
started this conversation in
Show and tell
Replies: 2 comments
-
|
Yes please — open the PR! Pointers so it lands smoothly:
Since you mentioned being new to contributing: fork → branch → PR against |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Hi,
I'll do my best to follow instructions. I will need a little time.
Regards.
Le mer. 10 juin 2026 à 20:05, Tirth Kanani ***@***.***> a
écrit :
… Yes please — open the PR! Pointers so it lands smoothly:
- The hook commands are generated in code_review_graph/skills.py (
generate_hooks_config for Claude Code, generate_codex_hooks_config for
Codex); a PowerShell variant gated on sys.platform == "win32" (or a
--shell option) belongs there rather than in static files.
- Keep the two invariants the bash versions have: drain stdin first
and fail open (the PowerShell equivalents of cat >/dev/null || true;
and || true) — large PostToolUse payloads otherwise break pipes (#493
<#493>).
- Tests go in tests/test_skills.py — recent hook-robustness work (PR
#541 <#541>) added
a TestShippedHooksFiles class you can mirror, and also switched hook
installs to git rev-parse --git-path hooks, so build on current main.
Since you mentioned being new to contributing: fork → branch → PR against
main, and the PR template will walk you through the checklist (uv run
pytest, uv run ruff check). Happy to review.
—
Reply to this email directly, view it on GitHub
<#501?email_source=notifications&email_token=ASMKDTKKDDIQ6CO3HUDXGIT47GPOJA5CNFSNUABIM5UWIORPF5TWS5BNNB2WEL2ENFZWG5LTONUW63SDN5WW2ZLOOQXTCNZSGU2DIMZZUZZGKYLTN5XKMYLVORUG64VFMV3GK3TUVRTG633UMVZF6Y3MNFRWW#discussioncomment-17254439>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMKDTJD647BATBBJJKGP7T47GPOJAVCNFSNUABJKJSXA33TNF2G64TZHMYTCNRXG44DQMZUGE5UI2LTMN2XG43JN5XDWMJQGA4TOOBWG2QXMAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
I've converted the shell hooks to powershell to allow code-review to work directly under windows. How to propose them to the repo (I'm new to contrib).
Here is an exemple (common script + pre-commit) in attachment
crg-hook-common.txt
crg-pre-commit.txt
I've converted the others too. Let me know if it interests you.
Kind regards
Beta Was this translation helpful? Give feedback.
All reactions