Go modernize + upgrade Go (#413)

* Ran `go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...`
* Minimum Go version 1.23 (removed build tags)
* Upgrade tinygo

Author: klauspost

.github/workflows/test.yml

@@ -21,7 +21,7 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.22.x, 1.23.x, 1.24.x]
+        go-version: [1.23.x, 1.24.x, 1.25.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     timeout-minutes: 10

.github/workflows/validate.yml

@@ -21,7 +21,7 @@ jobs:
   linters:
     strategy:
       matrix:
-        go-version: [1.24.x]
+        go-version: [1.25.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     timeout-minutes: 10
@@ -35,5 +35,5 @@ jobs:
       - name: lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.1.6
+          version: v2.5.0
           args: --print-resources-usage --timeout=10m --verbose

Makefile

@@ -55,8 +55,8 @@ ci: prepare
 	if [ `arch` == 'x86_64' ]; then \
 		sudo apt-get -y -q update; \
 		sudo apt-get -y -q install build-essential; \
-		wget -q https://github.com/tinygo-org/tinygo/releases/download/v0.38.0/tinygo_0.38.0_amd64.deb; \
-		sudo dpkg -i tinygo_0.38.0_amd64.deb; \
+		wget -q https://github.com/tinygo-org/tinygo/releases/download/v0.39.0/tinygo_0.39.0_amd64.deb; \
+		sudo dpkg -i tinygo_0.39.0_amd64.deb; \
 		export PATH=$$PATH:/usr/local/tinygo/bin; \
 	fi
 	go test -v ./... ./_generated

gen/elem.go

@@ -2,6 +2,7 @@ package gen
 
 import (
 	"fmt"
+	"slices"
 	"strings"
 )
 
@@ -601,12 +602,7 @@ func (sf *StructField) HasTagPart(pname string) bool {
 	if len(sf.FieldTagParts) < 2 {
 		return false
 	}
-	for _, p := range sf.FieldTagParts[1:] {
-		if p == pname {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(sf.FieldTagParts[1:], pname)
 }
 
 type ShimMode int

gen/encode.go

@@ -27,7 +27,7 @@ func (e *encodeGen) Apply(dirs []string) error {
 	return nil
 }
 
-func (e *encodeGen) writeAndCheck(typ string, argfmt string, arg interface{}) {
+func (e *encodeGen) writeAndCheck(typ string, argfmt string, arg any) {
 	if e.ctx.compFloats && typ == "Float64" {
 		typ = "Float"
 	}

gen/marshal.go

@@ -62,7 +62,7 @@ func (m *marshalGen) Execute(p Elem, ctx Context) error {
 	return m.p.err
 }
 
-func (m *marshalGen) rawAppend(typ string, argfmt string, arg interface{}) {
+func (m *marshalGen) rawAppend(typ string, argfmt string, arg any) {
 	if m.ctx.compFloats && typ == "Float64" {
 		typ = "Float"
 	}

gen/spec.go

@@ -462,7 +462,7 @@ func (p *printer) comment(s string) {
 	p.print("\n// " + s)
 }
 
-func (p *printer) printf(format string, args ...interface{}) {
+func (p *printer) printf(format string, args ...any) {
 	if p.err == nil {
 		_, p.err = fmt.Fprintf(p.w, format, args...)
 	}

go.mod

@@ -1,6 +1,6 @@
 module github.com/tinylib/msgp
 
-go 1.22
+go 1.23
 
 require (
 	github.com/philhofer/fwd v1.2.0

issue185_test.go

@@ -133,7 +133,7 @@ func TestIssue185Overlap(t *testing.T) {
 	}
 }
 
-func loadVars(t *testing.T, tpl *template.Template, tplData interface{}) (vars extractedVars, err error) {
+func loadVars(t *testing.T, tpl *template.Template, tplData any) (vars extractedVars, err error) {
 	tempDir := t.TempDir()
 
 	if !debugTemp {
@@ -218,7 +218,7 @@ func extractVars(file string) (extractedVars, error) {
 	return vars, nil
 }
 
-func goGenerateTpl(cwd, tfile string, tpl *template.Template, tplData interface{}) error {
+func goGenerateTpl(cwd, tfile string, tpl *template.Template, tplData any) error {
 	outf, err := os.OpenFile(tfile, os.O_CREATE|os.O_RDWR|os.O_TRUNC, 0o600)
 	if err != nil {
 		return err

main.go

@@ -44,7 +44,7 @@ var (
 	directives = stringArrFlags{}
 )
 
-func diagf(f string, args ...interface{}) {
+func diagf(f string, args ...any) {
 	if !*verbose {
 		return
 	}