Skip to content

Gate Playwright candidate readiness#54

Draft
giaphutran12 wants to merge 1 commit into
codex/self-healing-process-tracefrom
codex/playwright-candidate-artifacts
Draft

Gate Playwright candidate readiness#54
giaphutran12 wants to merge 1 commit into
codex/self-healing-process-tracefrom
codex/playwright-candidate-artifacts

Conversation

@giaphutran12
Copy link
Copy Markdown
Collaborator

Summary

Stacked on #53 (codex/self-healing-process-trace).

This deliberately does not emit a Playwright script yet. A reviewer rejected the fake path: current process traces have search/fetch/source outcomes, but not browser selectors/actions. So this PR adds the honest gate before any compiler exists.

  • Extends PopulateRuntimeTraceStep with a browser step kind and optional browserAction payload.
  • Adds playwrightCandidateReadinessForRun.
  • Persists a playwright-candidate-readiness artifact beside process-trace.
  • Marks search/fetch-only traces as not_ready.
  • Marks Agent-disabled browser/form/detail diagnostics as not_ready.
  • Allows ready only when trace contains actionable browser steps plus source URLs.
  • Keeps playwright-candidate-script reserved and un-emitted.

Why

The meeting shape was:

agent/search/fetch process -> documented process -> Playwright script -> cron

#53 made the documented process real. This PR makes the Playwright handoff honest: no script gets claimed until the trace has actual browser action truth.

Verification

  • node --import ./backend/node_modules/tsx/dist/esm/index.mjs --test backend/test/populate-playwright-readiness.test.ts backend/test/populate-self-healing.test.ts
  • npm --prefix backend run build
  • npm --prefix backend test
  • git diff --check
  • node --check benchmarks/dataset-agent/run-benchmark.mjs
  • make verify-self-healing

@giaphutran12 giaphutran12 self-assigned this May 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42467efe-a166-4ee5-bba6-6fdfb4518c06

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/playwright-candidate-artifacts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant