Installer - User credentials default to demo

[andrewcouling]

I have just completed an installation of latest code fetched from master branch, but have ran into an issue.

It was a fresh installation, into an empty database.
I did not install the demo data.
Although I entered my preferred user ID, email address, and password in the installation process, once the installer had completed, these credentials were not accepted at the login page.
Within the login page, I noticed the demo credentials prompt e.g. admin/weberp, so tried to gain access using these, and was able to log in.
By checking in phpMyAdmin I have verified that the demo data was not installed into the database (no items, customers, or suppliers), and 'admin' is the only user account.

In the resultant config.php file:
$AllowDemoMode = True; - I didn't select to install the demo data
$SysAdminEmail = the email i entered in the installer - OK
$AllowCompanySelectionBox = 'ShowSelectionBox'; - Imho, this is required only if there are multiple companies installed
$DefaultTheme = 'xenos'; - Although this was present in config.php, when i logged in for the first time, the theme named 'Default' was selected. Is this redundant, as default theme is defined in SystemParameters.php ?
$DefaultClock = 12; - Like default theme, shouldn't this be defined in SystemParameters.php ? If not, should we offer a choice between 12/24 hour clock during the installation process?

//Installed companies
$CompanyList[0] = array('database'=>'weberpdemo' ,'company'=>'WebERP Demo Company' ); - Displays here even though i did not want the demo to be installed
$CompanyList[1] = array('database'=>'your_db' ,'company'=>'Your Company inc' ); - Does not seem to have been affected by my database name/user or company name input

Additional things I spotted:

1. As I declined to install the demo data, I was surprised to see 'webERPDemo Company Ltd' available as an option in the 'Company' dropdown box on the login page, in addition to my chosen company name.

2. On page 5 of the installer, the Company Name field appears to inherit its value from either 'database name' or 'database user' from the previous page (sorry I cant determine which, as these inputs are identical for my set-up), and I don't understand why. I would expect that most users would want to input a real company name here, instead of a database name/username.

3. Current version shown in footer is 4.15.1+10

4. A new directory has been created in companies, and my custom logo has been uploaded successfully (I have verified by downloading the logo image), but it doesn't display correctly in the top left corner of the page header. Changing between themes doesn't impact this:
   

5. Without any post-install configuration, on Stocks.php, I unexpectedly see fields for french language input, even though I selected english language during the installation process:
   

6. After creating a stock category, I try to create a new stock item on Stocks.php. The following page doesn't render correctly (only a page heading displays), and the new item is not created. The following web server error is generated. I gather this is because a Tax Category is not defined yet, but I feel there should be a message box prompting me to create one.

erp-repo.handloomholdings.com [Fri Dec 13 01:03:19 2024] [error] [client 212.56.99.66:0] AH01071: Got error 'PHP message: PHP Fatal error: Uncaught mysqli_sql_exception: Cannot add or update a child row: a foreign key constraint fails (weberp-repo-353037355684.stockmaster, CONSTRAINT stockmaster_ibfk_2 FOREIGN KEY (taxcatid) REFERENCES taxcategories (taxcatid)) in /home/sites/3a/2/2b806fa8d9/public_html/erp-repo/includes/ConnectDB_mariadb.inc:58\nStack trace:\n#0 /home/sites/3a/2/2b806fa8d9/public_html/erp-repo/includes/ConnectDB_mariadb.inc(58): mysqli_query(Object(mysqli), 'INSERT INTO sto...')\n#1 /home/sites/3a/2/2b806fa8d9/public_html/erp-repo/Stocks.php(660): DB_query('INSERT INTO sto...', 'The item could ...', 'The SQL that wa...', '', true)\n#2 {main}\n thrown in /home/sites/3a/2/2b806fa8d9/public_html/erp-repo/includes/ConnectDB_mariadb.inc on line 58'

7. On Stocks.php, after creating a Tax Category, I am able to create an item without selecting a Unit of Measure. Is it correct that this field is not mandatory? If it should be, can there be a warning message prompting me to define units of measure?
8. After I have created an item, an open search for any item (or specific to an item code) in SelectProduct.php returns zero items, although I can see in the database that an item has been created. I receive the message "No stock items were returned by this search please re-enter alternative criteria to try again".

[andrewcouling]

Please let me know if I should split this report into separate issues

[dalers]

I unexpectedly see fields for french language input,

I have found the same behavior, I suspect this feature applies only to Canada where both English and French descriptions for an Item must be maintained, and presume everyone else simply ignores the "Français Description" and "Français Long Description" fields.

It may be the feature works generically for "any language and French" field, but either a configuration variable would need to exist to specify using the French descriptions instead of the "other" language, or perhaps reports using the French fields were created as custom site-specific reports and not managed by the webERP project.