feat: Implement flush for pending edits before saving notes to capture in-progress changes

Author: timothywarner

TimmyTools.WpfUi/ViewModels/NoteViewModel.cs

@@ -53,6 +53,12 @@ ThemeService themeService
 
     public NoteModel Note { get; set; } = null!;
 
+    // The View sets this to flush pending TextBox bindings before each save.
+    // Needed because RtfContent uses UpdateSourceTrigger=LostFocus to keep
+    // selection stable during typing — without a flush, periodic saves would
+    // miss in-progress edits.
+    public Action? FlushPendingEdits { get; set; }
+
     public async Task Initialize(int? noteId = null, NoteModel? parent = null, nint? managementWindowHandle = null)
     {
         if (noteId is null)
@@ -117,6 +123,8 @@ public void UpdateAlwaysOnTop()
 
     public async Task SaveNote()
     {
+        FlushPendingEdits?.Invoke();
+
         if (Note.IsSaved)
             return;
 

TimmyTools.WpfUi/Views/NoteWindow.xaml

@@ -272,7 +272,7 @@
                                          FontSize="18"
                                          x:Name="NoteTextBox"
                                          Padding="5,5,5,5"
-                                         RtfContent="{Binding Note.Content, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
+                                         RtfContent="{Binding Note.Content, Mode=TwoWay, UpdateSourceTrigger=LostFocus}"
 
                                          SpellCheck.IsEnabled="{Binding EditorSettings.CheckSpelling}"
                                          NewLineAtEnd="{Binding EditorSettings.NewLineAtEnd}"

TimmyTools.WpfUi/Views/NoteWindow.xaml.cs

@@ -48,10 +48,17 @@ public NoteWindow(SettingsService settingsService, MessengerService messengerSer
 
         InitializeComponent();
 
+        // Flush the LostFocus-triggered RtfContent binding before each save
+        // so the periodic auto-save still captures in-progress edits.
+        _viewModel.FlushPendingEdits = () =>
+            BindingOperations.GetBindingExpression(
+                NoteTextBox,
+                Controls.NoteTextBoxControl.RtfContentProperty
+            )?.UpdateSource();
+
         Activated += Window_Activated;
         Closing += Window_Closing;
         Deactivated += Window_Deactivated;
-        MouseDown += NoteWindow_MouseDown;
         MouseEnter += Window_MouseEnter;
         MouseLeave += Window_MouseLeave;
         Loaded += Window_Loaded;
@@ -104,18 +111,6 @@ private void Window_Loaded(object sender, RoutedEventArgs e)
         );
     }
 
-    private void NoteWindow_MouseDown(object sender, MouseButtonEventArgs e)
-    {
-        // Check mouse button is pressed as a missed click of a button
-        // can cause issues with DragMove().
-        if (e.LeftButton != MouseButtonState.Pressed)
-            return;
-
-        DragMove();
-
-        _viewModel.OnWindowMoved(Left, Top);
-    }
-
     private void NoteWindow_StateChanged(object? sender, EventArgs e)
     {
         if (WindowState == WindowState.Minimized)
@@ -144,7 +139,9 @@ private void Window_Activated(object? sender, EventArgs e)
     {
         _viewModel.Note.IsFocused = true;
         _viewModel.UpdateOpacity();
-        _viewModel.UpdateAlwaysOnTop();
+        // Defer the topmost toggle past the current input gesture so it
+        // doesn't reorder the window mid-click/drag and disrupt selection.
+        Dispatcher.BeginInvoke(_viewModel.UpdateAlwaysOnTop, System.Windows.Threading.DispatcherPriority.Input);
         ShowTitleBar();
     }