[Feature Request] Wordlists with > 65536 words

[ProjectCleverWeb]

Right now, if you supply a wordlists with more than 65536 words, it errors our with:

$poolSize must be between 2 and 65536

If you change Random::MAX_ALLOWED_POOL_SIZE to 16,777,216 (2^24) and Random::MAX_ALLOWED_POWER_OF_TWO to 2,147,483,648 (2^31) you could start supporting wordlists with up to 16,777,216 words.

Right now, in order to get my current wordlist to work (125,000 words), I have had to change these values manually. But there's no reason I can think of why this shouldn't be supported out of the box?

[timoh6]

I think it is enough if we just adjust the MAX_ALLOWED_POOL_SIZE to, say, 262144. This should not affect performance too much (the cases a new random number have to be generated as it is too high) and should be great enough for wordlists (that I can think of).

Adjusting MAX_ALLOWED_POWER_OF_TWO to a bigger number shouldn't be a problem per se, 2^25 would be fine, but testing the random int generator for uniform distribution gets slower (much bigger range of numbers).

I think MAX_ALLOWED_POOL_SIZE: 262144 and MAX_ALLOWED_POWER_OF_TWO: 33554432 would be a reasonable compromise. What do you think?

[ProjectCleverWeb]

You are probably right, and 262,144 definitely fixes my issue. However, I am always bias towards solutions that are more future-proof (not that anything ever actually is "future-proof").

Also, I am only suggesting that the max values change and not the default values. If I understand the code correctly, you would still need to use the below code to actually allow a max pool size of 16,777,216. Which you could add to the README file with a big notice about how "increasing these values can reduce performance/speed."

use \GenPhrase\Password;
use \GenPhrase\Random\Random;

$random_provider = new Random;
$random_provider->setPowerOfTwo(2147483648);
$random_provider->setMaxPoolSize(16777216);
$genphrase = new Password(NULL, NULL, $random_provider);
$password  = $genphrase->generate(55);

Beyond that, I could only recommend changing the error message from:

$poolSize must be between 2 and 65536

To something like:

Your wordlist file is too big, please reduce how many words it contains or increase the maximum random pool size. (current max size is set to <insert current pool size>)

[timoh6]

This looks reasonable. I'll increase max pool size and max power of two. I'm thinking 1048576 as max pool size and 2^26 (67108864) as max power of two.

How urgent you need these changes to be tagged or can you go with your current version? I'd need to adjust some tests and add some documentation, and beyond that I'd need to fix previous pull-request (as it makes a hard-requirement for Composer). These thing sorted out I'll be able to tag a new version.

Thanks!

[ProjectCleverWeb]

Well I have already drilled down in composer and manually changed the values, so there's no rush. Just close this issue when the libraries been updated and I will update the library and make the adjustment to my code then.

Thank You!

[timoh6]

I'll try to get new version tagged next week. There shouldn't be other changes affecting functionality than increasing max pool size to 1048576 and max power of two to 67108864.

[ProjectCleverWeb]

Hello again!

Hope things have been going well fore you. Happen to come see this issue again and decided to check back in. Is there any chance you would be willing to resolve this issue soon?

[timoh6]

Hello,

damn, I got stuck to a previous pull-request which changed quite a lot of the code, but removed the ability to use GenPhrase without Composer.

I may just revert to v1.2.1 and make this change to adjust max poolsize and power of two and tag 1.2.2.

I'll try to do it sooner rather than later. Sorry about the enormous delay!

[ProjectCleverWeb]

No problem! Thanks you for your hard work!

[timoh6]

Now the change is finally in master. I'll tag it as v1.3.0 after a while.

Let me know if any issues arise.