enhancement: fix Cetelem bank transations (actualbudget#5914)

* enhancement: fix Cetelem bank transations

The amount coming from GoCardless has the opposite sign of what we expect.

* Cetelem bank: make code more future-proof

Change based on code review suggestion

Co-authored-by: Matt Fiddaman <[email protected]>

---------

Co-authored-by: Matt Fiddaman <[email protected]>

Author: 2 people

packages/sync-server/src/app-gocardless/banks/cetelem_cetmptp1xxx.js

@@ -0,0 +1,23 @@
+import Fallback from './integration-bank.js';
+
+/** @type {import('./bank.interface.js').IBank} */
+export default {
+  ...Fallback,
+
+  institutionIds: ['CETELEM_CETMPTP1XXX'],
+
+  /**
+   * Sign of transaction amount needs to be flipped for Cetelem Black credit cards
+   */
+  normalizeTransaction(transaction, booked) {
+    const editedTrans = { ...transaction };
+
+    transaction.transactionAmount = {
+      // Flip transaction amount sign
+      ...transaction.transactionAmount,
+      amount: (-parseFloat(transaction.transactionAmount.amount)).toString(),
+    };
+
+    return Fallback.normalizeTransaction(transaction, booked, editedTrans);
+  },
+};

upcoming-release-notes/5914.md

@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [andreparames]
+---
+
+fix Cetelem bank transactions: Sign of transaction amount needs to be flipped for Cetelem Black credit cards