Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from mockr to testthat for mocking #456

Open
georgestagg opened this issue Jul 22, 2024 · 1 comment
Open

Switch from mockr to testthat for mocking #456

georgestagg opened this issue Jul 22, 2024 · 1 comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day upkeep maintenance, infrastructure, and similar

Comments

@georgestagg
Copy link
Member

No description provided.

@hadley hadley added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jul 22, 2024
@jennybc
Copy link
Member

jennybc commented Jul 22, 2024

In general, getting into position to fully run googledrive's tests locally is a big commitment.

But from a quick look, I've only used mocking in tests that don't require auth, i.e. tests of internal utilities that don't hit the Drive API. So it seems like this would be feasible for tidyverse dev day. If someone picks this up, you can expect to see lots of skipped tests, but the tests you're touching should run. And then once the PR is pushed, full tests will be run in CI.

@jennybc jennybc added the upkeep maintenance, infrastructure, and similar label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

3 participants