Skip to content

Commit fd0eaec

Browse files
committed
Another revdep run. Update cran-comments
1 parent e8dee8c commit fd0eaec

File tree

2 files changed

+1540
-1552
lines changed

2 files changed

+1540
-1552
lines changed

cran-comments.md

Lines changed: 54 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,65 @@
1-
This submission of ggplot2 fixes \donttest{} examples.
2-
31
## Test environments
4-
* OS X, R 3.1.3
5-
* OS X, R-devel
6-
* Ubuntu 14.04, R 3.1.3
2+
* OS X, R 3.2.2
3+
* Ubuntu 14.04, R 3.2.2
74
* win-builder (devel and release)
85

96
## R CMD check results
107

11-
There were no ERRORs or WARNINGs in R 3.1.3. On R-devel with --as-cran, there was also this NOTE:
8+
There were no ERRORs, WARNINGs, or NOTEs.
129

13-
Found the following (possibly) invalid URLs:
14-
URL: http://fueleconomy.gov
15-
From: man/mpg.Rd
16-
Status: 404
17-
Message: Not Found
10+
## Downstream dependencies
1811

19-
This URL is accessible through a web browser, though apparently not via R CMD check.
12+
This version of ggplot2 contains substantial changes (hence the bump in the major version number), and I've done my best to get the reverse dependencies updated. I started the release process over two months ago, and I have notified maintainers three times (and I'll notify them again today).
2013

14+
Unfortunately there are still widespread check failures (mostly new WARNINGS). They are mostly caused by three changes:
2115

22-
On R-devel for Windows x64, the tests hung and did not complete. We encountered some similar strange errors in our local testing, until we rebuilt and reinstalled packages from source. After doing that, the R CMD CHECK passed as above without problems.
16+
* ggplot2 now imports and exports `unit()` and `arrow()` from grid, and
17+
`alpha()` from scales. Many packages seem to have unused unqualified import
18+
statements which now generates a warning on package install. (You could argue
19+
that this is a false positive since the conflicting names both point to the
20+
same object.). This affects:
21+
22+
alm, arqas, benchmark, blowtorch, clhs, conformal, Deducer, DTRlearn, dynsim,
23+
extracat, FAOSTAT, fheatmap, FinCal, gettingtothebottom, GGally, gwmw,
24+
HistDAWass, hyperspec, kobe, likert, lsbclust, marketeR, Methplot, micromap,
25+
MissingDataGUI, mizer, MultiMeta, ncappc, nparACT, optiRum, patPRO,
26+
PortfolioEffectHFT, PPtreeViz, PReMiuM, prevR, primerTree, qicharts,
27+
quadrupen, RAM, RDS, RFmarkerDetector, rfPermute, RobustEM, rotations, RSDA,
28+
SCGLR, sjPlot, soc.ca, sparkTable, spikeSlabGAM, spoccutils, sprm, statebins,
29+
strvalidator, survMisc, tcR, TreatmentSelection, TriMatch, UpSetR, useful,
30+
varian, waffle
2331

24-
## Downstream dependencies
25-
We did not run checks on downstream dependencies, because there were no behaviour modifying changes to the code.
32+
* ggplot2 makes extensive use of ..., and previously little checking was done
33+
on the contents. Now ggplot2 is much stricter about ... which causes a number
34+
of warnings, where previously the function silently did the wrong thing.
35+
This afffects:
36+
37+
AmplicoDuo, chemosensors, clifro, dpcR, granovaGG, GraphPCA, HistDAWass,
38+
knitrBootstrap, LOGIT, lsbclust, mlr, multitable, oaxaca, pAnalysis, PASWR2,
39+
patPRO, PDQutils, planar, RAM, reproducer, rex, rfordummies, sdmvspecies,
40+
SensMixed, simmer, SixSigma, sjPlot, spcosa, ss3sim, starma, survMisc, tcR,
41+
treecm, userfriendlyscience, vcdExtra, vdmR, wq, xkcd
42+
43+
* A few packages linked to the ggplot2 documentation topic, which didn't
44+
actualy contain anything useful. I removed the file, so a number of packges
45+
now give warnings about a missing link. This affects:
46+
47+
PopED, precrec, RcmdrPlugin.KMggplot2points, simPH, statebins
48+
49+
Finally, there were a grab bag of other failures:
2650

51+
* CosmoPhotoz: uses a newly deprecated function
52+
* cowplot: uses a newly deprecated function
53+
* directlabels: ?? think this is long standing (??)
54+
* ggswissmaps (looks like it was relying on an internal API that's changed)
55+
* ggmcmc (from GGally error)
56+
* metricsgraphics (relies on movies data which has moved to ggplot2movies)
57+
* OutbreakTools: downstream error from ggmap
58+
* plot2groups: used internal StatHline which is no longer exported
59+
* plotly: used internal StatVline which is no longer exported
60+
* precintcon: ?? not ggplot2 related?
61+
* RCell: used internal functions where API has changed
62+
* robustlmm: ?? not ggplot2 related?
63+
* SWMPr: downstream error from ggmap
64+
* synthpop: ?? not ggplot2 related?
65+
* TreatmentSelection: used internal stat_hline which is now longer exported

0 commit comments

Comments
 (0)