Skip to content

Commit 96ff666

Browse files
authored
Merge pull request #326 from hbugdoll/title-fix
fix(ios): removed unsupported title property
2 parents 39a2761 + 39f3bad commit 96ff666

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ In order to use the `close` event on Android it is recommended to have a short d
2929
* `animated` (Boolean, iOS only)
3030
* `entersReaderIfAvailable` (Boolean, iOS only)
3131
* `barCollapsingEnabled` (Boolean)
32-
* `title` (String, iOS only)
3332
* `tintColor` (String, iOS only)
3433
   * `dismissButtonStyle` (`DISMISS_BUTTON_STYLE_*`, iOS only)
3534
* `showTitle` (Boolean, Android only)

apidoc/WebDialog.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ description: |
4242
``` javascript
4343
if (dialog.isSupported()) {
4444
dialog.open({
45-
url: 'https://appcelerator.com'
45+
url: 'https://titaniumsdk.com'
4646
});
4747
}
4848
```
@@ -92,8 +92,7 @@ methods:
9292
var dialog = require('ti.webdialog');
9393
if (dialog.isSupported()) {
9494
dialog.open({
95-
url: 'https://appcelerator.com',
96-
title: 'Hello World',
95+
url: 'https://titaniumsdk.com',
9796
tintColor: 'red'
9897
});
9998
}
@@ -170,12 +169,6 @@ properties:
170169
type: Boolean
171170
platforms: [iphone, ipad]
172171

173-
- name: title
174-
summary: The URL to be opened.
175-
optional: true
176-
type: String
177-
platforms: [iphone, ipad]
178-
179172
- name: tintColor
180173
summary: The tint-color of the web dialog.
181174
optional: true

ios/Classes/TiWebdialogModule.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,6 @@ - (void)open:(id)args
137137

138138
SFSafariViewController *safari = [self safariController:_url withEntersReaderIfAvailable:entersReaderIfAvailable andBarCollapsingEnabled:barCollapsingEnabled];
139139

140-
if ([args objectForKey:@"title"]) {
141-
[safari setTitle:[TiUtils stringValue:@"title" properties:args]];
142-
}
143-
144140
if ([args objectForKey:@"tintColor"]) {
145141
TiColor *newColor = [TiUtils colorValue:@"tintColor" properties:args];
146142
[safari setPreferredControlTintColor:[newColor _color]];

0 commit comments

Comments
 (0)