This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Foresight Concurrency Support(Do Not Merge) #176
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokhan721
requested review from
erdogan-yesil,
serkan-ozal and
suleymanbarman
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-parallel plugin fork the pytest main process for running test individually. It also reshape the pytest origin flow by overriding run test hooks. These cause the problem for current Foresight flow. Finish test run status data can not be prepared properly because of forked process. Handling this issue brings the enormous code change for the current logic. For now, we can only get test suite context in correct way. But, test runs always depict zero. To solve this problem, shared memory can be used but first processes that forked by pytest-parallel plugin should be detected and shared memory name is passed them as attribute. Also, forked processes' can be multi threaded. We also consider thread safety in the solution as well.