Skip to content

shim: health endpoint #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pepyakin opened this issue Dec 12, 2023 · 4 comments
Open

shim: health endpoint #108

pepyakin opened this issue Dec 12, 2023 · 4 comments

Comments

@pepyakin
Copy link
Contributor

Docker has a feature referred to as HEALTHCHECK. It allows running a predefined command that checks health of the container. It may be a nice-to-have for ops. It is also useful for docker-compose since it allows specifying depends_on for start up order and ideally the demo containers should start only after the shim is up.
@rphmeier
Copy link
Contributor

this could be an RPC added to the shim?

@pepyakin
Copy link
Contributor Author

Yes. Should be very simple. HEALTHCHECK CMD rawdogging with curl an JSONRPC endpoint works.

@pepyakin pepyakin mentioned this issue Dec 15, 2023
Closed
@gabriele-0201 gabriele-0201 mentioned this issue Jan 11, 2024
Closed
@gabriele-0201
Copy link
Contributor

Is this achieved with #191 , as described in #128?

@pepyakin
Copy link
Contributor Author

No, it's not. The condition for closing this issue is presence of a working integrated healthcheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pepyakin @rphmeier @gabriele-0201