Improve speed - reducing waittime

Author: thorstenalpers

src/UI/Scripts/delete-all-posts.js

@@ -7,7 +7,7 @@ async function DeleteAllPosts(waitAfterDelete, waitBetweenDeleteAttempts) {
         console.log(`[${new Date().toLocaleTimeString()}] ${msg}`);
     }
 
-    async function waitForDeleteButton(selector, maxWait = 8000, interval = 300) {
+    async function waitForDeleteButton(selector, maxWait = 3000, interval = 200) {
         const start = Date.now();
         while (true) {
             const caret = document.querySelector(selector);
@@ -29,7 +29,6 @@ async function DeleteAllPosts(waitAfterDelete, waitBetweenDeleteAttempts) {
 
     async function clickDeleteOnPost() {
         log("[clickDeleteOnPost] Searching for caret button...");
-
         const caretButton = document.querySelector("div[data-testid='primaryColumn'] section button[data-testid='caret']");
         if (!caretButton) {
             log("[clickDeleteOnPost] Caret button not found.");
@@ -39,7 +38,7 @@ async function DeleteAllPosts(waitAfterDelete, waitBetweenDeleteAttempts) {
         caretButton.click();
         await delay(waitBetweenDeleteAttempts);
 
-        const delays = [1, 2, 3, 4, 5].map(i => i * waitBetweenDeleteAttempts);
+        const delays = [100, 200, 300]; // 3 short retries
 
         async function tryClickDelete(attempt = 0) {
             if (attempt >= delays.length) {
@@ -75,7 +74,7 @@ async function DeleteAllPosts(waitAfterDelete, waitBetweenDeleteAttempts) {
 
         async function confirmDelete(attempt = 0) {
             if (attempt >= delays.length) {
-                log("[confirmDelete] Confirm delete button not found after retries.");
+                log("[confirmDelete] Confirm button not found after retries.");
                 return false;
             }
 
@@ -104,25 +103,33 @@ async function DeleteAllPosts(waitAfterDelete, waitBetweenDeleteAttempts) {
 
     window.postsDeletionDone = false;
     window.deletedPosts = 0;
-
     log("[DeleteAllPosts] Starting deletion loop...");
 
     let failures = 0;
-    const maxFailures = 3;
+    const maxFailures = 1;
     let postNumber = 1;
 
     while (failures < maxFailures) {
-        const found = await waitForDeleteButton("div[data-testid='primaryColumn'] section button[data-testid='caret']", 8000, 300);
+        const found = await waitForDeleteButton("div[data-testid='primaryColumn'] section button[data-testid='caret']", 3000, 200);
         if (!found) {
             failures++;
-            log(`[DeleteAllPosts] No post found (failure #${failures}). Scrolling up for retry...`);
+            log(`[DeleteAllPosts] No post found (failure #${failures}). Scrolling up...`);
+
+            const prevScroll = window.scrollY;
             window.scrollTo(0, 0);
-            await delay(500);
+            await delay(400);
+
+            if (window.scrollY === prevScroll) {
+                log("[DeleteAllPosts] No scroll change. Assuming no more posts.");
+                break;
+            }
+
             continue;
         }
 
         log(`[DeleteAllPosts] Deleting post #${postNumber}...`);
         const success = await clickDeleteOnPost();
+
         if (success) {
             window.deletedPosts++;
             log(`[DeleteAllPosts] Deleted post #${postNumber}`);
@@ -132,7 +139,7 @@ async function DeleteAllPosts(waitAfterDelete, waitBetweenDeleteAttempts) {
         } else {
             failures++;
             log(`[DeleteAllPosts] Failed to delete post #${postNumber} (failure #${failures})`);
-            await delay(500);
+            await delay(300);
         }
     }
 

src/UI/Scripts/delete-all-replies.js

@@ -4,24 +4,31 @@ async function DeleteAllReplies(userName, waitAfterDelete, waitBetweenDeleteAtte
     }
 
     function isVisible(el) {
-        return el && el.offsetParent !== null;
+        return el && !!(el.offsetWidth || el.offsetHeight || el.getClientRects().length);
+    }
+
+    function isReplyByUser(article, userName) {
+        const userLink = article.querySelector(`a[href^="/${userName}"]`);
+        const repostMarker = article.innerText.includes("Reposted");
+        return userLink && !repostMarker;
     }
 
     async function waitForReplyCaret(maxWait = 5000, interval = 200) {
         const start = Date.now();
         while (Date.now() - start < maxWait) {
-            const caret = document.querySelector("article[data-testid='tweet'] button[data-testid='caret']");
-            if (caret && isVisible(caret)) return true;
+            const articles = Array.from(document.querySelectorAll("article[data-testid='tweet']"));
+            const match = articles.find(article => isReplyByUser(article, userName));
+            if (match) return true;
 
-            window.scrollBy(0, 500);
+            window.scrollBy(0, 600);
             await delay(interval);
         }
         return false;
     }
 
-    async function findCaretWithRetry(article, maxRetries = 5, delayMs = 300) {
+    async function findCaretWithRetry(article, maxRetries = 5, delayMs = 200) {
         for (let i = 0; i < maxRetries; i++) {
-            const caret = article.querySelector("button[data-testid='caret']");
+            const caret = article.querySelector("div[aria-label='More']/div > div > div");
             if (caret && isVisible(caret)) return caret;
             await delay(delayMs);
         }
@@ -35,10 +42,8 @@ async function DeleteAllReplies(userName, waitAfterDelete, waitBetweenDeleteAtte
             for (const item of menuItems) {
                 const span = item.querySelector("span");
                 if (!span) continue;
-
-                const color = getComputedStyle(span).color;
-                const [r, g, b] = color.match(/\d+/g).map(Number);
-                if (r > 180 && g < 100 && b < 100) {
+                const text = span.innerText.toLowerCase();
+                if (text.includes("delete")) {
                     span.click();
                     return true;
                 }
@@ -50,7 +55,7 @@ async function DeleteAllReplies(userName, waitAfterDelete, waitBetweenDeleteAtte
     async function tryConfirmDelete(attempts, baseDelay) {
         for (let i = 0; i < attempts; i++) {
             await delay(baseDelay * (i + 1));
-            const confirmBtn = document.querySelector("button[data-testid='confirmationSheetConfirm']");
+            const confirmBtn = document.querySelector("div[role='dialog'] button[data-testid='confirmationSheetConfirm']");
             if (confirmBtn && isVisible(confirmBtn)) {
                 confirmBtn.click();
                 return true;
@@ -61,13 +66,13 @@ async function DeleteAllReplies(userName, waitAfterDelete, waitBetweenDeleteAtte
 
     async function clickDeleteOnReply() {
         const articles = Array.from(document.querySelectorAll("article[data-testid='tweet']"));
-        const replyArticle = articles.find(article => article.querySelector(`a[href*="/${userName}"]`));
+        const replyArticle = articles.find(article => isReplyByUser(article, userName));
         if (!replyArticle) {
             console.log("[clickDeleteOnReply] No matching reply article found.");
             return false;
         }
 
-        const caret = await findCaretWithRetry(replyArticle, 6, 300);
+        const caret = await findCaretWithRetry(replyArticle);
         if (!caret) {
             console.log("[clickDeleteOnReply] Caret not found in reply article.");
             return false;
@@ -76,13 +81,13 @@ async function DeleteAllReplies(userName, waitAfterDelete, waitBetweenDeleteAtte
         caret.click();
         await delay(waitBetweenDeleteAttempts);
 
-        const deleteClicked = await tryClickDeleteMenuItem(5, waitBetweenDeleteAttempts);
+        const deleteClicked = await tryClickDeleteMenuItem(3, waitBetweenDeleteAttempts);
         if (!deleteClicked) {
             console.log("[clickDeleteOnReply] Failed to click delete menu item.");
             return false;
         }
 
-        const confirmed = await tryConfirmDelete(5, waitBetweenDeleteAttempts);
+        const confirmed = await tryConfirmDelete(3, waitBetweenDeleteAttempts);
         if (!confirmed) {
             console.log("[clickDeleteOnReply] Failed to confirm deletion.");
             return false;
@@ -95,7 +100,7 @@ async function DeleteAllReplies(userName, waitAfterDelete, waitBetweenDeleteAtte
     window.deletedReplies = 0;
 
     while (true) {
-        const found = await waitForReplyCaret(5000, 200);
+        const found = await waitForReplyCaret(7000, 200);
         if (!found) {
             console.log("[DeleteAllReplies] No more visible replies.");
             break;