fix: added missing typings

Author: thorsten

phpmyfaq/faq.php

@@ -188,7 +188,7 @@
 $multiCategories = $category->getCategoriesFromFaq($faqId);
 if ((is_countable($multiCategories) ? count($multiCategories) : 0) > 1) {
     foreach ($multiCategories as $multiCategory) {
-        $path = $category->getPath($multiCategory['id'], ' » ', true, 'list-unstyled');
+        $path = $category->getPath((int) $multiCategory['id'], ' » ', true, 'list-unstyled');
         if ('' === trim($path)) {
             continue;
         }
@@ -213,7 +213,7 @@
 
 // Number of comments
 $numComments = $comment->getNumberOfComments();
-$comments = $comment->getCommentsData($faqId, CommentType::FAQ);
+$comments = $comment->getCommentsData((int) $faqId, CommentType::FAQ);
 
 $commentHelper = new CommentHelper();
 $commentHelper->setConfiguration($faqConfig);

phpmyfaq/src/phpMyFAQ/Comments.php

@@ -64,8 +64,8 @@ public function getCommentsData(int $referenceId, string $type): array
             while ($row = $this->configuration->getDb()->fetchObject($result)) {
                 $comment = new Comment();
                 $comment
-                    ->setId($row->id_comment)
-                    ->setRecordId($row->id)
+                    ->setId((int) $row->id_comment)
+                    ->setRecordId((int) $row->id)
                     ->setComment($row->comment)
                     ->setDate(Date::createIsoDate($row->datum, DateTimeInterface::ATOM, false))
                     ->setUsername($row->usr)

phpmyfaq/src/phpMyFAQ/Helper/FaqHelper.php

@@ -72,7 +72,7 @@ public function renderChangeLanguageSelector(Faq $faq, int $categoryId): string
         $oLink = new Link($this->configuration->getDefaultUrl() . $faqUrl, $this->configuration);
         $oLink->itemTitle = $faq->faqRecord['title'];
 
-        $availableLanguages = $this->configuration->getLanguage()->isLanguageAvailable($faq->faqRecord['id']);
+        $availableLanguages = $this->configuration->getLanguage()->isLanguageAvailable((int) $faq->faqRecord['id']);
 
         if ((is_countable($availableLanguages) ? count($availableLanguages) : 0) > 1) {
             $html = '<form method="post">';

phpmyfaq/src/phpMyFAQ/Search/SearchResultSet.php

@@ -80,30 +80,28 @@ public function reviewResultSet(array $resultSet): void
         $this->setResultSet($resultSet);
 
         $duplicateResults = [];
+        $currentGroupIds = [-1];
 
         if ('basic' !== $this->configuration->get('security.permLevel')) {
-            // @phpstan-ignore-next-line
             $currentGroupIds = $this->currentUser->perm->getUserGroups($this->currentUser->getUserId());
-        } else {
-            $currentGroupIds = [-1];
         }
 
         foreach ($this->rawResultSet as $result) {
             $permission = false;
 
             // check permissions for groups
             if ('medium' === $this->configuration->get('security.permLevel')) {
-                $groupPermissions = $this->faqPermission->get(Permission::GROUP, $result->id);
+                $groupPermissions = $this->faqPermission->get(Permission::GROUP, (int) $result->id);
                 foreach ($groupPermissions as $groupPermission) {
                     if (in_array($groupPermission, $currentGroupIds)) {
                         $permission = true;
                     }
                 }
             }
 
-            // check permission for user
+            // check permission for a user
             if ('basic' === $this->configuration->get('security.permLevel')) {
-                $userPermission = $this->faqPermission->get(Permission::USER, $result->id);
+                $userPermission = $this->faqPermission->get(Permission::USER, (int) $result->id);
                 $permission =
                     in_array(-1, $userPermission) || in_array($this->currentUser->getUserId(), $userPermission);
             }