feat: Support Exporter Metadata #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
feat-exporter-metadata
branch
from
73bbcb3 to
6786c20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 85.90% 86.36% +0.45%
==========================================
Files 22 23 +1
Lines 1107 1144 +37
==========================================
+ Hits 951 988 +37
Misses 156 156 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
GO Feature Flag exporter is now supporting adding extra parameters as metadata.
Those parameters are static informations provided during the initialisation to be added in the meta field when calling the exporter.
In the GO Feature Flag we will have those information available in the exporter.
See thomaspoignant/go-feature-flag#2936 for more information.
Related Issues
Fixes thomaspoignant/go-feature-flag#2942