Skip to content

Commit b161be6

Browse files
authored
Add PHP 8.4 support and align CI matrix with PHP constraint (#141)
1 parent 3699704 commit b161be6

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

.github/workflows/php.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,8 @@ jobs:
1212
max-parallel: 15
1313
matrix:
1414
laravel-version: [^10.0, ^11.0, ^12.0]
15-
php-versions: ['8.1', '8.2', '8.3']
15+
php-versions: ['8.2', '8.3', '8.4']
1616
exclude:
17-
- laravel-version: '^10.0'
18-
php-versions: '8.1'
19-
- laravel-version: '^11.0'
20-
php-versions: '8.1'
2117
- laravel-version: '^12.0'
2218
php-versions: '8.2'
2319

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"illuminate/support": "^10.0 | ^11.0 | ^12.0"
2121
},
2222
"require-dev": {
23-
"orchestra/testbench": "^8.0 | ^9.0",
23+
"orchestra/testbench": "^8.0 | ^9.0 | ^10.0",
2424
"phpunit/phpunit": "^10.0 | ^11.0",
2525
"timacdonald/log-fake": "^2"
2626
},

src/ScheduledNotification.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public static function create(
6666
]));
6767
}
6868

69-
public static function getPendingNotifications(int $tolerance = null): \Illuminate\Database\Eloquent\Collection
69+
public static function getPendingNotifications(?int $tolerance = null): \Illuminate\Database\Eloquent\Collection
7070
{
7171
$modelClass = self::getScheduledNotificationModelClass();
7272

0 commit comments

Comments
 (0)