Built in Nethereum serialization scheme

thirdweb-dev · May 21, 2023 · a7e39ec · a7e39ec
1 parent c5e2501
commit a7e39ec
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/Assets/Thirdweb/Core/Scripts/Wallet.cs b/Assets/Thirdweb/Core/Scripts/Wallet.cs
@@ -479,7 +479,8 @@ public async Task<string> Sign(string message)
             }
         }
 
-        public async Task<string> SignTypedDataV4<T>(T data, TypedData<Domain> typedData)
+        public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain> typedData)
+            where TDomain : IDomain
         {
             switch (ThirdwebManager.Instance.SDK.nativeSession.provider)
             {

diff --git a/Assets/Thirdweb/Plugins/MetaMask/Scripts/MetaMaskUnity.cs b/Assets/Thirdweb/Plugins/MetaMask/Scripts/MetaMaskUnity.cs
@@ -251,7 +251,8 @@ public async Task<string> PersonalSign(string message)
             return result.GetString();
         }
 
-        public async Task<string> SignTypedDataV4<T>(T data, TypedData<Domain> typedData)
+        public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain> typedData)
+            where TDomain : IDomain
         {
             var request = new MetaMaskEthereumRequest { Method = "eth_signTypedData_v4", Parameters = new string[] { Wallet.SelectedAddress, typedData.ToJson(data) } };
             var result = await MetaMaskUnity.Instance.Wallet.Request(request);

diff --git a/Assets/Thirdweb/Plugins/WalletConnectSharp.Unity/WalletConnect.cs b/Assets/Thirdweb/Plugins/WalletConnectSharp.Unity/WalletConnect.cs
@@ -469,7 +469,7 @@ public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain>
             where TDomain : IDomain
         {
             var address = Session.Accounts[0];
-            return await WalletConnectNEthereumExtensions.EthSignTypedData(Session, address, data, typedData);
+            return await Session.EthSignTypedData(address, data, typedData);
         }
     }
 }
diff --git a/Assets/Thirdweb/Plugins/magic-unity/link.magic.unity.sdk/Prefabs/Scripts/MagicUnity.cs b/Assets/Thirdweb/Plugins/magic-unity/link.magic.unity.sdk/Prefabs/Scripts/MagicUnity.cs
@@ -63,7 +63,8 @@ public async Task<string> PersonalSign(string message)
         return await personalSign.SendRequestAsync(await GetAddress(), message);
     }
 
-    public async Task<string> SignTypedDataV4<T>(T data, TypedData<Domain> typedData)
+    public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain> typedData)
+        where TDomain : IDomain
     {
         throw new NotImplementedException("Magic does not support EIP712");
     }