Skip to content

Commit a7e39ec

Browse files
committed
Built in Nethereum serialization scheme
1 parent c5e2501 commit a7e39ec

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

Assets/Thirdweb/Core/Scripts/Wallet.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,8 @@ public async Task<string> Sign(string message)
479479
}
480480
}
481481

482-
public async Task<string> SignTypedDataV4<T>(T data, TypedData<Domain> typedData)
482+
public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain> typedData)
483+
where TDomain : IDomain
483484
{
484485
switch (ThirdwebManager.Instance.SDK.nativeSession.provider)
485486
{

Assets/Thirdweb/Plugins/MetaMask/Scripts/MetaMaskUnity.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,8 @@ public async Task<string> PersonalSign(string message)
251251
return result.GetString();
252252
}
253253

254-
public async Task<string> SignTypedDataV4<T>(T data, TypedData<Domain> typedData)
254+
public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain> typedData)
255+
where TDomain : IDomain
255256
{
256257
var request = new MetaMaskEthereumRequest { Method = "eth_signTypedData_v4", Parameters = new string[] { Wallet.SelectedAddress, typedData.ToJson(data) } };
257258
var result = await MetaMaskUnity.Instance.Wallet.Request(request);

Assets/Thirdweb/Plugins/WalletConnectSharp.Unity/WalletConnect.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain>
469469
where TDomain : IDomain
470470
{
471471
var address = Session.Accounts[0];
472-
return await WalletConnectNEthereumExtensions.EthSignTypedData(Session, address, data, typedData);
472+
return await Session.EthSignTypedData(address, data, typedData);
473473
}
474474
}
475475
}

Assets/Thirdweb/Plugins/magic-unity/link.magic.unity.sdk/Prefabs/Scripts/MagicUnity.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ public async Task<string> PersonalSign(string message)
6363
return await personalSign.SendRequestAsync(await GetAddress(), message);
6464
}
6565

66-
public async Task<string> SignTypedDataV4<T>(T data, TypedData<Domain> typedData)
66+
public async Task<string> SignTypedDataV4<T, TDomain>(T data, TypedData<TDomain> typedData)
67+
where TDomain : IDomain
6768
{
6869
throw new NotImplementedException("Magic does not support EIP712");
6970
}

0 commit comments

Comments
 (0)