Skip to content

Commit 4602118

Browse files
committed
add test, remove redundant check
1 parent 64c0460 commit 4602118

File tree

2 files changed

+29
-4
lines changed

2 files changed

+29
-4
lines changed

contracts/signature-drop/SignatureDrop.sol

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,6 @@ contract SignatureDrop is
178178
payable
179179
returns (address signer)
180180
{
181-
if (_req.quantity == 0) {
182-
revert("0 qty");
183-
}
184-
185181
uint256 tokenIdToMint = _currentIndex;
186182
if (tokenIdToMint + _req.quantity > nextTokenIdToLazyMint) {
187183
revert("Not enough tokens");

src/test/SignatureDrop.t.sol

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,6 +916,35 @@ contract SignatureDropTest is BaseTest {
916916
sigdrop.mintWithSignature(mintrequest, signature);
917917
}
918918

919+
/**
920+
* note: Testing revert condition; minting zero tokens.
921+
*/
922+
function test_revert_mintWithSignature_zeroQuantity() public {
923+
vm.prank(deployerSigner);
924+
sigdrop.lazyMint(100, "ipfs://", emptyEncodedBytes);
925+
uint256 id = 0;
926+
927+
SignatureDrop.MintRequest memory mintrequest;
928+
mintrequest.to = address(0x567);
929+
mintrequest.royaltyRecipient = address(2);
930+
mintrequest.royaltyBps = 0;
931+
mintrequest.primarySaleRecipient = address(deployer);
932+
mintrequest.uri = "ipfs://";
933+
mintrequest.quantity = 0;
934+
mintrequest.pricePerToken = 0;
935+
mintrequest.currency = address(3);
936+
mintrequest.validityStartTimestamp = 1000;
937+
mintrequest.validityEndTimestamp = 2000;
938+
mintrequest.uid = bytes32(id);
939+
940+
bytes memory signature = signMintRequest(mintrequest, privateKey);
941+
vm.warp(1000);
942+
943+
vm.prank(deployerSigner);
944+
vm.expectRevert("0 qty");
945+
sigdrop.mintWithSignature(mintrequest, signature);
946+
}
947+
919948
/**
920949
* note: Testing revert condition; not enough minted tokens.
921950
*/

0 commit comments

Comments
 (0)