fix workflows (#342)

* fix workflows

* has to be called action.yml I guess

* need to check out first, duh

* add shell

* make test runner beefier

* further workflow improvements

Author: jnsdls

.github/composite-actions/setup/action.yml

@@ -0,0 +1,16 @@
+name: "Install"
+description: "Sets up Node.js and runs install"
+
+runs:
+  using: composite
+  steps:
+    - name: Setup Node.js
+      uses: actions/setup-node@v3
+      with:
+        node-version: 16
+        registry-url: "https://registry.npmjs.org"
+        cache: "yarn"
+
+    - name: Install dependencies
+      shell: bash
+      run: yarn

.github/workflows/lint.yml

@@ -6,26 +6,32 @@ name: Solhint Lint
 on:
   # Triggers the workflow on push or pull request events but only for the main branch
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
+
+# cancel previous runs if new commits are pushed to the branch
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   # This workflow contains a single job called "build"
-  build:
+  lint:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v3
         with:
           submodules: recursive
-      - name: Setup Node.js environment
-        uses: actions/[email protected]
-      # Runs a single command using the runners shell
-      - name: Run npm install
-        run: yarn
-      - name: Run lint
+          fetch-depth: 25
+
+      - name: Setup Project
+        uses: ./.github/composite-actions/setup
+
+      - name: Run Lint
         run: yarn lint

.github/workflows/prettier.yml

@@ -6,26 +6,31 @@ name: Prettier Formatting
 on:
   # Triggers the workflow on push or pull request events but only for the main branch
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
+
+# cancel previous runs if new commits are pushed to the branch
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
-# A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   # This workflow contains a single job called "build"
-  build:
+  lint:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v3
         with:
           submodules: recursive
-      - name: Setup Node.js environment
-        uses: actions/[email protected]
-      # Runs a single command using the runners shell
-      - name: Run npm install
-        run: yarn
-      - name: Run prettier:contracts
+          fetch-depth: 25
+
+      - name: Setup Project
+        uses: ./.github/composite-actions/setup
+
+      - name: Run Prettier
         run: yarn prettier:contracts

.github/workflows/slither.yml

@@ -6,6 +6,11 @@ on:
   pull_request:
     branches: [main]
 
+# cancel previous runs if new commits are pushed to the branch
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   analyze:
     runs-on: ubuntu-latest
@@ -14,15 +19,13 @@ jobs:
       security-events: write
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           submodules: recursive
+          fetch-depth: 25
 
-      - name: Setup Node.js environment
-        uses: actions/[email protected]
-
-      - name: Run npm install
-        run: yarn
+      - name: Setup Project
+        uses: ./.github/composite-actions/setup
 
       - name: Install Foundry
         uses: onbjerg/foundry-toolchain@v1

.github/workflows/tests.yml

@@ -10,23 +10,30 @@ on:
   pull_request:
     branches: [main]
 
+# cancel previous runs if new commits are pushed to the branch
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   # This workflow contains a single job called "build"
-  build:
+  test:
     # The type of runner that the job will run on
-    runs-on: ubuntu-latest
+    # 16 core paid runner
+    runs-on: ubuntu-latest-16
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v3
         with:
           submodules: recursive
-      - name: Setup Node.js environment
-        uses: actions/[email protected]
-      # Runs a single command using the runners shell
-      - name: Run npm install
-        run: yarn
+          fetch-depth: 25
+
+      - name: Setup Project
+        uses: ./.github/composite-actions/setup
+
       - name: Install Foundry
         uses: onbjerg/foundry-toolchain@v1
         with: