Removed Jason decoding exception

Author: thiagoesteves

apps/deployer/lib/deployer/github/release.ex

@@ -62,27 +62,25 @@ defmodule Deployer.Github.Release do
       |> Finch.build(@deployex_latest_tag, [], [])
       |> Finch.request(Deployer.Finch)
 
-    case response do
-      {:ok, %{body: body}} ->
-        info = Jason.decode!(body)
-
-        tag_name = info["tag_name"]
-        prerelease = info["prerelease"]
-        current_version = Application.spec(:foundation, :vsn) |> to_string
-
-        new_release? =
-          tag_name != nil and prerelease == false and new_release?(current_version, tag_name)
-
-        %__MODULE__{
-          tag_name: tag_name,
-          prerelease: prerelease,
-          new_release?: new_release?,
-          created_at: info["created_at"],
-          updated_at: info["updated_at"],
-          published_at: info["published_at"]
-        }
-
-      {:error, _reason} ->
+    with {:ok, %{body: body}} <- response,
+         {:ok, info} <- Jason.decode(body) do
+      tag_name = info["tag_name"]
+      prerelease = info["prerelease"]
+      current_version = Application.spec(:foundation, :vsn) |> to_string
+
+      new_release? =
+        tag_name != nil and prerelease == false and new_release?(current_version, tag_name)
+
+      %__MODULE__{
+        tag_name: tag_name,
+        prerelease: prerelease,
+        new_release?: new_release?,
+        created_at: info["created_at"],
+        updated_at: info["updated_at"],
+        published_at: info["published_at"]
+      }
+    else
+      _any ->
         # NOTE: Keep the latest state, since the application may not have acceess to
         #       network or GitHub is not available
         state

apps/deployer/test/github_test.exs

@@ -163,23 +163,6 @@ defmodule Deployer.GithubTest do
     end
   end
 
-  test "handles invalid JSON response" do
-    previous_state = %Release{tag_name: "1.0.0"}
-
-    with_mock Finch, [:passthrough],
-      request: fn %Finch.Request{
-                    host: "api.github.com",
-                    path: "/repos/thiagoesteves/deployex/releases/latest"
-                  },
-                  _module ->
-        {:ok, %{body: "invalid json {"}}
-      end do
-      assert_raise Jason.DecodeError, fn ->
-        Release.update_github_info(previous_state)
-      end
-    end
-  end
-
   # Helper functions
   defp build_mock_response(overrides \\ %{}) do
     Map.merge(