This repository was archived by the owner on May 8, 2021. It is now read-only.
Enable vte sixel support #773
Closed
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VTE [added support for sixel](https://gitlab.gnome.org/GNOME/vte/-/issues/253#note_886802) but then [subsequently reverted it](https://gitlab.gnome.org/GNOME/vte/-/commit/b11351e19e61a5bf07ddad6587af24211dd7e63c). However, when removing the support, the public API was left as stubs (and in fact support has since been re-added behind a build flag). This PR adds a call to enable VTE sixel support (with a new config option `enable_sixel` to disable if desired) which will be a no-op on VTE versions that were built without support but will do the right thing once VTE fully releases support (or when linking against a VTE that was built with the relevant flag).
|
@jelly I think you're the right person to tag? |
|
Going to close this because as far as I can tell, termite is effectively abandonware so I've stopped using it, and won't be able to actually support this change or make any requested modifications. If I'm wrong about it being abandonware let me know and I'm happy to re-open this PR but I won't be making any modifications or any further support for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772.
VTE added support for sixel but then subsequently reverted it. However, when removing the support, the public API was left as stubs (and in fact support has since been re-added behind a build flag). This PR adds a call to enable VTE sixel support (with a new config option
enable_sixelto disable if desired) which will be a no-op on VTE versions that were built without support but will do the right thing once VTE fully releases support (or when linking against a VTE that was built with the relevant flag).